Repository navigation
feat: add deployment smoke test selection - #797
Draft
bschwedler wants to merge 3 commits into
Draft
bschwedler wants to merge 3 commits into
bschwedler wants to merge 3 commits into
Conversation
Provide a positive smoke-test selection for cheap deployment checks instead of relying on brittle test-name filters. Tag health, version, and Package Manager homepage scenarios so workflows can run the repository-free basics without provisioning package repositories.
The text-encoding selftest requires write_text() calls to pass encoding="utf-8" so tests behave the same on Windows. The new --smoke selftests omitted it and failed that check.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Credential preflight and authenticated fixture dependencies still block public smoke checks on URL-only deployments.
1 open issue
What changed in this PR
Adds an explicit smoke-test selection to VIP for lightweight deployment checks, separate from the broader --basic scope.
Changes:
- Adds
vip verify --smoke, composing with category and basic-mode filters. - Tags component reachability, product-version, and Package Manager homepage checks as smoke scenarios.
- Documents the smoke scope and adds CLI selection tests.
| File | Description |
|---|---|
src/vip/plugin/configure.py |
Registers the smoke marker in the installed plugin. |
src/vip/cli/verify.py |
Builds smoke marker expressions with existing filters. |
src/vip/cli/app.py |
Exposes the --smoke option. |
src/vip_tests/prerequisites/test_versions.feature |
Tags version checks as smoke scenarios. |
src/vip_tests/prerequisites/test_components.feature |
Tags reachability checks as smoke scenarios. |
src/vip_tests/package_manager/test_ui.feature |
Tags the homepage rendering scenario as smoke. |
selftests/test_cli_verify.py |
Tests smoke selection and filter composition. |
pyproject.toml |
Registers the smoke marker for repository test runs. |
docs/test-architecture.md |
Defines smoke selection and its intended scope. |
Review effort: Balanced
Comment on lines
+512
to
+513
| if getattr(args, "smoke", False): | ||
| marker_expr = "smoke" |
Contributor
|
Preview Links
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a positive smoke selection for lightweight deployment checks without selecting scenarios that require seeded product state. Expose it through
vip verify --smoke, composing with category and basic-mode filters.