Repository navigation
spaces on selectors (or containers in general) don't work #172
Description
parser
.pseudo({
value: ':not',
nodes: [
selectorParser.selector({
nodes: [selectorParser.tag({ value: 'span' })],
spaces: { before: ' ', after: ' ' },
}),
selectorParser.selector({
nodes: [selectorParser.tag({ value: 'span' })],
spaces: { before: ' ', after: ' ' },
}),
],
})
.toString() // ':not(span,span)'I think the idea is that the spaces go on the nodes, but that's a bit unwieldy of an API when walking through the or transforming selectors, since you drill down and find the first non-container thing to apply spacing too.
Activity
alexander-akait commentedon Feb 19, 2019
@jquense thanks for issue, why don't use
rawSpaceBeforeandrawSpaceAfter?jquense commentedon Feb 19, 2019
i don't know how too! :) I didn't see that in the documentation. The problem I'm running into here is the case where we replace a pseudo selector with it's children.
its a bit awkward to do:
psuedo.first.first.spaces = psuedo.spacesalexander-akait commentedon Feb 19, 2019
@jquense hm,
rawSpaceBeforeandrawSpaceAfterdon't work or it is inconvenient?jquense commentedon Feb 19, 2019
they may work, i just don't know what they are. looking at the code tho, toString() for containers doesn't use them?
alexander-akait commentedon Feb 19, 2019
@jquense here contains https://github.com/postcss/postcss-selector-parser/blob/master/src/selectors/node.js#L180
jquense commentedon Feb 19, 2019
gotcha, yeah that works for a
nodebutselectors are containers and they don't call super() on toString() https://github.com/postcss/postcss-selector-parser/blob/master/src/selectors/container.js#L317This may be intentional, it's hard to know if you what to do if you put spaces on both the first node and the selector itself. Overall its more inconvenient than anything, and makes the case where the inner node doesn't exist yet hard
alexander-akait commentedon Feb 19, 2019
@jquense do you have ideas how we can improve this? You can send a PR and we can discussion in a PR
alexander-akait commentedon Feb 25, 2019
/cc @jquense friendly ping
jquense commentedon Feb 26, 2019
I don't have a good suggestion right now unfortunately. I'd be nicer if the logic in postcss-local-by-default could be simplified but i'm not sure the right way to handle it given the way this package works