make check is failing #442

Activity

1. ixti

   added

   bug

   on Feb 20, 2023
2. postmodern commented on Feb 20, 2023

   

   postmodern

   on Feb 20, 2023

   Owner

   More actions

   I disabled many of the erroneous ShellCheck rules that were giving false positives, and fixed a few legitimate issues as well. Feel free to help out with the remaining linting errors.

   In share/ruby-install/checksums.sh line 33:
   	local output="$(grep "  $file" "$checksums")"
                 ^----^ SC2155: Declare and assign separately to avoid masking return values.
   
   
   In share/ruby-install/checksums.sh line 58:
   	local output="$($program "$file")"
                 ^----^ SC2155: Declare and assign separately to avoid masking return values.
   
   
   In share/ruby-install/checksums.sh line 74:
   	local actual_checksum="$(compute_checksum "$algorithm" "$file")"
                 ^-------------^ SC2155: Declare and assign separately to avoid masking return values.
   
   
   In share/ruby-install/functions.sh line 22:
   	ruby_dependencies=($(fetch "$ruby/$file" "$package_manager" || return $?))
                              ^-- SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
   
   
   In share/ruby-install/package_manager.sh line 32:
   			local brew_owner="$(/usr/bin/stat -f %Su "$(command -v brew)")"
                                 ^--------^ SC2155: Declare and assign separately to avoid masking return values.
   
   
   In share/ruby-install/package_manager.sh line 43:
   			local missing_pkgs=($(pacman -T "$@"))
                                               ^---------------^ SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
   
   
   In share/ruby-install/ruby-install.sh line 275:
   	local fully_qualified_version="$(lookup_ruby_version "$ruby" "$ruby_version")"
                 ^---------------------^ SC2155: Declare and assign separately to avoid masking return values.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
     https://www.shellcheck.net/wiki/SC2207 -- Prefer mapfile or read -a to spli...
   

   ❤️React with ❤️1Reacted by Alexey Zapparov
3. postmodern

   added

   lintingLinting issuesLinting issues

   help-wanted

   and removed

   bug

   on Feb 20, 2023
4. ixti commented on Feb 21, 2023

   

   ixti

   on Feb 21, 2023

   Author

   More actions

   Opened a PR with fixes to the above linting errors.