Repository navigation
Tier change - #1837
Merged
Merged
Tier change#1837
Conversation
When a ClusterProfile's tier is raised above a challenger's tier, the challenger (stuck in FailedNonRetriable) was never woken up and never took over management of the chart. The root cause was a gap in the conflict-resolution path. Once a profile was managing a chart, its tier was never compared against other conflicting profiles on subsequent reconciliations. CanManageChart returned true immediately for the current manager, so determineChartOwnership was never called and no tier comparison ran. This PR fixes. When a ClusterSummary is reconciled, even if that profile is already managing the chart, its tier is compared with all other profiles trying to managed same chart. Tests - Unit tests for requeueLowerTierChallengers: verifies a lower-tier challenger is requeued (status reset to Provisioning) and a higher-tier challenger is left untouched. - Extended test/fv/tier_test.go: after profile2 takes over kyverno by dropping to tier 50, raises it back to 100 and verifies profile1 (tier 90) reclaims the chart and profile2 enters conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ClusterProfile's tier is raised above a challenger's tier, the challenger (stuck in FailedNonRetriable) was never woken up and never took over management of the chart. The root cause was a gap in the conflict-resolution path. Once a profile was managing a chart, its tier was never compared against other conflicting profiles on subsequent reconciliations. CanManageChart returned true immediately for the current manager, so determineChartOwnership was never called and no tier comparison ran.
This PR fixes. When a ClusterSummary is reconciled, even if that profile is already managing the chart, its tier is compared with all other profiles trying to managed same chart.
Tests
Fixes #1836