Repository navigation
gh-160217: Fix premature client socket cleanup in test_socket - #160218
Open
NikitaMikhailov wants to merge 2 commits into
Open
NikitaMikhailov wants to merge 2 commits into
NikitaMikhailov wants to merge 2 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-160217.
NetworkConnectionAttributesTest registers client socket close callbacks on the shared TestCase cleanup stack. The server thread can run these callbacks before it reaches done.wait, closing the socket while the client is still checking it. This caused testSourceAddress to fail with EBADF in the MSan job for gh-159859.
Remove the five redundant client socket close callbacks. clientTearDown() already closes the socket in the client thread, and clientRun() always calls it in a finally block. All address and timeout assertions remain in place.
Validation:
This changes only tests, so no NEWS entry is needed.
AI assistance: Codex helped diagnose the race, prepare the change and deterministic reproducer, and run validation.