Repository navigation
Conversation
p-sawicki
added a commit
that referenced
this pull request
Oct 26, 2026
#22287 makes mypyc no longer add the parent's frame to the traceback before forwarding an exception injected with `throw()` to an awaited coroutine. This means that the traceback can be empty and we might call `throw(type, exception, None)` which incorrectly results in a type error on Python 3.11.1 as seen in [CI](https://github.com/python/mypy/actions/runs/39997005770/job/120563034921?pr=22287). Relevant issue: python/cpython#101326. Use newer Python 3.11 version in the 32-bit job which includes a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling single-argument
throw(ex)on a coroutine or generator, thetracebackargument isNone, so passing it toPyErr_Restoreclears the existing exception traceback. Recover the traceback from the exception instead to match interpreted Python.Don't add a traceback entry when forwarding an exception injected through
throw()atawait/yield from. Otherwise, the child coro/gen would see the parent's frame in its traceback. The parent's entry is still added when propagating the exception, so this also avoids a duplicated entry.