Adapt sym quantizer to ET (#24875) by mgiordy · Pull Request #24875 · pytorch/executorch

mgiordy · 2026-11-11T00:16:30Z

Summary:

Summary

This diff includes a symmetric 8 bit quantizer in ET.

Differential Revision: D91777784

pytorch-bot · 2026-11-11T00:16:35Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24875

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 618a0a9 with merge base 6411f1e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2026-11-11T00:16:39Z

The committers listed above are authorized under a signed CLA.

✅ login: mgiordy / name: Marco Giordano (618a0a9)

meta-codesync · 2026-11-11T00:16:41Z

@mgiordy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91777784.

github-actions · 2026-11-11T00:17:38Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

🟢 Approval recommended

The review reports no active issues with the symmetric W8A32 quantization changes.

No open issues 🎉

What changed in this PR

This PR updates Cadence’s mixed W8A32 quantizer to use a symmetric signed 8-bit range of [-127, 127] for weights and biases while keeping activations in floating point.

Changes:

Adds the symmetric quantization specification and applies it to linear, convolution, and GRU patterns.
Adds annotation and range tests, removing the mixed quantizer’s annotation-test exclusion.

File	Description
`backends/cadence/aot/tests/test_quantizer_ops.py`	Adds W8A32 annotation checks and a symmetric weight-range assertion.
`backends/cadence/aot/quantizer/quantizer.py`	Defines and applies the `[-127, 127]` configuration for mixed W8A32 quantization.

_{Review effort: Balanced}

Summary: # Summary This diff includes a symmetric 8 bit quantizer in ET. Differential Revision: D91777784

Copilot

🟡 Changes recommended

The GRU test checks only the quantization spec type, not that b_hh shares with (b_ih, gru_node), so an incorrect bias-scale relationship could pass.

1 open issue

GRU test does not verify the bias quantization sharing edge · New

_{Review effort: Balanced}

+        self.assertEqual(annotation.input_qspec_map.keys(), expected.keys())
+        for arg, qspec in expected.items():
+            if isinstance(qspec, type):
+                self.assertIsInstance(annotation.input_qspec_map[arg], qspec)


Copilot

🟡 Changes recommended

The tests cover only configuration and annotation, leaving converted and fused quantization values, scales, outputs, and GRU bias observer sharing unverified.

2 open issues

_{Review effort: Balanced}

+    def test_w8a32_weight_range_is_symmetric(self) -> None:
+        weight_qspec = qconfig_A32W8sym_127.weight
+        assert weight_qspec is not None
+        self.assertEqual((weight_qspec.quant_min, weight_qspec.quant_max), (-127, 127))


Summary: # Summary This diff includes a symmetric 8 bit quantizer in ET. Differential Revision: D91777784

Copilot

🔵 Needs a closer look

The GRU test does not verify that b_hh shares quantization parameters specifically with b_ih, allowing an incorrect sharing target to pass and silently alter fused GRU results.

2 open issues

_{Review effort: Balanced}

Summary: # Summary This diff includes a symmetric 8 bit quantizer in ET. Differential Revision: D91777784

Copilot

🟢 Approval recommended

No active review issues are reported for the mixed W8A32 symmetric-int8 range update.

2 open issues

_{Review effort: Balanced}

mgiordy requested review from mcremon-meta and rascani as code owners November 11, 2026 00:16

Copilot AI balanced review requested due to automatic review settings November 11, 2026 00:16

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2026

meta-codesync Bot added the meta-exported label Nov 11, 2026

mgiordy temporarily deployed to cadence November 11, 2026 00:16 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mgiordy November 11, 2026 00:17

View session

Copilot AI reviewed Nov 11, 2026

View reviewed changes

mgiordy temporarily deployed to cadence November 11, 2026 00:30 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 11, 2026 00:31 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 11, 2026 00:34 — with GitHub Actions Inactive

meta-codesync Bot changed the title ~~Adapt sym quantizer to ET~~ Adapt sym quantizer to ET (#24875) Nov 12, 2026

mgiordy force-pushed the export-D91777784 branch from dc7f125 to 078628c Compare November 12, 2026 00:24

Copilot AI balanced review requested due to automatic review settings November 12, 2026 00:24

mgiordy added a commit to mgiordy/executorch that referenced this pull request Nov 12, 2026

Adapt sym quantizer to ET (pytorch#24875)

078628c

Summary: # Summary This diff includes a symmetric 8 bit quantizer in ET. Differential Revision: D91777784

mgiordy temporarily deployed to cadence November 12, 2026 00:24 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mgiordy November 12, 2026 00:25

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread backends/cadence/aot/tests/test_quantizer_ops.py

self.assertEqual(annotation.input_qspec_map.keys(), expected.keys())

for arg, qspec in expected.items():

if isinstance(qspec, type):

self.assertIsInstance(annotation.input_qspec_map[arg], qspec)

mgiordy temporarily deployed to cadence November 12, 2026 00:39 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 12, 2026 00:41 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 12, 2026 06:59 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mgiordy November 12, 2026 06:59

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

mgiordy temporarily deployed to cadence November 12, 2026 07:13 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 12, 2026 07:15 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 12, 2026 07:16 — with GitHub Actions Inactive

mgiordy force-pushed the export-D91777784 branch from a406f9c to 68e63e3 Compare November 12, 2026 19:57

mgiordy added a commit to mgiordy/executorch that referenced this pull request Nov 12, 2026

Adapt sym quantizer to ET (pytorch#24875)

68e63e3

Summary: # Summary This diff includes a symmetric 8 bit quantizer in ET. Differential Revision: D91777784

Copilot AI balanced review requested due to automatic review settings November 12, 2026 19:57

mgiordy temporarily deployed to cadence November 12, 2026 19:57 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mgiordy November 12, 2026 19:58

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

mgiordy temporarily deployed to cadence November 12, 2026 20:11 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 12, 2026 20:13 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 12, 2026 20:17 — with GitHub Actions Inactive

Adapt sym quantizer to ET (pytorch#24875)

618a0a9

Summary: # Summary This diff includes a symmetric 8 bit quantizer in ET. Differential Revision: D91777784

mgiordy force-pushed the export-D91777784 branch from 68e63e3 to 618a0a9 Compare November 12, 2026 23:47

Copilot AI balanced review requested due to automatic review settings November 12, 2026 23:47

mgiordy temporarily deployed to cadence November 12, 2026 23:47 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mgiordy November 12, 2026 23:47

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

mgiordy temporarily deployed to cadence November 13, 2026 00:01 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 13, 2026 00:04 — with GitHub Actions Inactive

mgiordy temporarily deployed to cadence November 13, 2026 00:05 — with GitHub Actions Inactive

Navigation Menu

Repository navigation

Adapt sym quantizer to ET (#24875) - #24875

Adapt sym quantizer to ET (#24875)#24875
mgiordy wants to merge 1 commit into
pytorch:mainfrom
mgiordy:export-D91777784

mgiordy commented Nov 11, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

pytorch-bot Bot commented Nov 11, 2026 •

edited

Loading

Uh oh!

linux-foundation-easycla Bot commented Nov 11, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Nov 11, 2026

Uh oh!

github-actions Bot commented Nov 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mgiordy commented Nov 11, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

pytorch-bot Bot commented Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24875

✅ No Failures

Uh oh!

linux-foundation-easycla Bot commented Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meta-codesync Bot commented Nov 11, 2026

Uh oh!

github-actions Bot commented Nov 11, 2026

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mgiordy commented Nov 11, 2026 •

edited by meta-codesync Bot

Loading

pytorch-bot Bot commented Nov 11, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Nov 11, 2026 •

edited

Loading

This PR needs a `release notes:` label