Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24907
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit d897d0b with merge base 0f6ba97 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127010336. |
SS-JIA
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
…#24907) Summary: A 3-D transposed convolution (ConvTranspose1d) was not delegated, so models had to rewrite it as a 4-D conv_transpose2d. It now runs on the transposed 2-D kernels with H = 1. Transposed convs with dynamic input, or whose direct user is relu/hardtanh, stay on CPU. This unblocks the upsamplers of streaming audio decoders, e.g. text-to-speech in the browser. Follow-up (pre-existing): ConvTranspose2d -> BatchNorm2d -> ReLU still fuses into a transposed conv_with_clamp, which fails to load. Reviewed By: SS-JIA Differential Revision: D127010336
e4af5d6 to
d897d0b
Compare
Summary:
A 3-D transposed convolution (ConvTranspose1d) was not delegated, so models had to rewrite it as a 4-D conv_transpose2d.
It now runs on the transposed 2-D kernels with H = 1. Transposed convs with dynamic input, or whose direct user is relu/hardtanh, stay on CPU.
This unblocks the upsamplers of streaming audio decoders, e.g. text-to-speech in the browser.
Follow-up (pre-existing): ConvTranspose2d -> BatchNorm2d -> ReLU still fuses into a transposed conv_with_clamp, which fails to load.
Reviewed By: SS-JIA
Differential Revision: D127010336