Skip to content

Run 1-D transposed convolution on the transposed 2-D kernels (#24907) - #24907

Open
psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:export-D127010336
Open

psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:export-D127010336

Conversation

@psiddh

@psiddh psiddh commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

A 3-D transposed convolution (ConvTranspose1d) was not delegated, so models had to rewrite it as a 4-D conv_transpose2d.
It now runs on the transposed 2-D kernels with H = 1. Transposed convs with dynamic input, or whose direct user is relu/hardtanh, stay on CPU.
This unblocks the upsamplers of streaming audio decoders, e.g. text-to-speech in the browser.
Follow-up (pre-existing): ConvTranspose2d -> BatchNorm2d -> ReLU still fuses into a transposed conv_with_clamp, which fails to load.

Reviewed By: SS-JIA

Differential Revision: D127010336

Copilot AI balanced review requested due to automatic review settings November 11, 2026 19:31
@pytorch-bot

pytorch-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24907

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit d897d0b with merge base 0f6ba97 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2026
@meta-codesync

meta-codesync Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127010336.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@SS-JIA SS-JIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…#24907)

Summary:

A 3-D transposed convolution (ConvTranspose1d) was not delegated, so models had to rewrite it as a 4-D conv_transpose2d.
It now runs on the transposed 2-D kernels with H = 1. Transposed convs with dynamic input, or whose direct user is relu/hardtanh, stay on CPU.
This unblocks the upsamplers of streaming audio decoders, e.g. text-to-speech in the browser.
Follow-up (pre-existing): ConvTranspose2d -> BatchNorm2d -> ReLU still fuses into a transposed conv_with_clamp, which fails to load.

Reviewed By: SS-JIA

Differential Revision: D127010336
@meta-codesync meta-codesync Bot changed the title Run 1-D transposed convolution on the transposed 2-D kernels Run 1-D transposed convolution on the transposed 2-D kernels (#24907) Nov 12, 2026
Copilot AI balanced review requested due to automatic review settings November 12, 2026 01:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants