[alanleedev]

Summary:
Remove unneeded code around size calculation and old arch support

• updateState was getting called unnecessarily in multiple places --> only call from onSizeChanged()
  • this is a reliable source for getting the content size area of the dialog used for Modal
  • remove code checking duplicated update
• Old architecture cleanup
  • Remove Java implementation of ShadowNode
    • we already have logic to set the node size via UIManagerModule::updateNodeSize(). This code is now group together in updateState() for both new and old architecture

This fixes issues with resulting from wrong size calculation:

• having gaps at bottom when we set statusBarTranslucent to true
• Modal cut off at bottom on Android 15 (drawn under bottom nav bar)

Changelog:
[Android][Fixed] - Modal statusBarTranslucent bug, Modal at bottom being cut off in Android 15 (without forced edge-to-edge)
[Android][Deprecation] - Deprecating ModalHostShadowNode and ModalHostHelper classes

Differential Revision: D62286026

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62286026

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62286026

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62286026

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62286026

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62286026

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62286026

[facebook-github-bot]

This pull request has been merged in 77b3a8b.

[react-native-bot]

This pull request was successfully merged by @alanleedev in 77b3a8b

^{When will my fix make it into a release? | How to file a pick request?}

[mysport12]

Hi @alanleedev. I am running the latest RC (0.76.0-rc.6) and still have some problems with statusBarTranslucent={true} for Android modals.

<Modal
      animationType="slide"
      onRequestClose={onClose}
      presentationStyle="overFullScreen"
      statusBarTranslucent={true}
      transparent={true}
      visible={true}>
      {Modal content rendered here}
</Modal>

The modal doesn't draw under the status bar and additionally gives it a white background (at least that appears to be the case).

After the modal is dismissed, the status bar remains visible.

For reference, I am setting the status bar translucent with the StatusBar component provided by RN. If I instead use the StatusBar component to hide the status bar...

<StatusBar hidden={true} backgroundColor="transparent" barStyle={barStyle} translucent={true} />

...the modal problem does not show itself both when the modal is open and afterward.

Based on commit history, you seem to be the most familiar with this topic so I hope that you are able to look into it and help out! I appreciate any and all help you are able to provide!

EDIT: I am running on the new arch and these screens were captured via a physical Google Pixel 4 Android version 13 running locally

[alanleedev]

@mysport12 Thanks for reporting.
Could you file a new issue with a Reproducer App?
Let me see if I understand correctly.
So when the Modal is visible status bar area turns white and goes back to normal after modal is dismissed?

[mysport12]

Yeah I will try and get it posted tomorrow. The issue arises while the modal is visible and persists after it is closed. Only if I have the status bar hidden does the issue not show itself.

[mysport12]

@alanleedev sorry for the alarm. Turns out I was missing a flag when using useAnimatedKeyboard from reanimated that was causing the status bar padding issue. Everything is good on the RN side.

[alanleedev]

@mysport12 Great to hear everything is working as expected.