Skip to content

Move PushNotificationIOS badge writes off the main thread #59208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fkgozali wants to merge 1 commit into from
Closed

Move PushNotificationIOS badge writes off the main thread #59208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,20 @@ static BOOL IsNotificationRemote(UNNotification *notification)
return [notification.request.trigger isKindOfClass:[UNPushNotificationTrigger class]];
}

// setBadgeCount: dispatch_syncs onto the UserNotifications connection queue, which another
// thread can hold for a whole usernotificationsd round trip. Serial so writes land in order.
static dispatch_queue_t RCTBadgeCountQueue(void)
{
static dispatch_queue_t queue;
static dispatch_once_t onceToken;
dispatch_once(&onceToken, ^{
queue = dispatch_queue_create(
"com.facebook.react.PushNotificationManager.badgeCount",
dispatch_queue_attr_make_with_qos_class(DISPATCH_QUEUE_SERIAL, QOS_CLASS_UTILITY, 0));
});
return queue;
}

RCT_EXPORT_MODULE()

- (dispatch_queue_t)methodQueue
Expand Down Expand Up @@ -324,13 +338,15 @@ - (void)setApplicationIconBadgeNumber:(double)number
{
NSInteger badgeCount = (NSInteger)lround(number);
if (@available(iOS 16.0, *)) {
[UNUserNotificationCenter.currentNotificationCenter
setBadgeCount:badgeCount
withCompletionHandler:^(NSError *_Nullable error) {
if (error != nil) {
RCTLogWarn(@"Failed to set application icon badge number: %@", error);
}
}];
dispatch_async(RCTBadgeCountQueue(), ^{
[UNUserNotificationCenter.currentNotificationCenter
setBadgeCount:badgeCount
withCompletionHandler:^(NSError *_Nullable error) {
if (error != nil) {
RCTLogWarn(@"Failed to set application icon badge number: %@", error);
}
}];
});
} else {
RCTSharedApplication().applicationIconBadgeNumber = badgeCount;
}
Expand Down
Loading