Skip to content

Packaging an iOS component - #7323

Closed
Hari70a wants to merge 6 commits into
react:masterfrom
Hari70a:master
Closed

Hari70a wants to merge 6 commits into
react:masterfrom
Hari70a:master

Conversation

@Hari70a

@Hari70a Hari70a commented May 2, 2016 •

Copy link
Copy Markdown

Here I have submitted a pull request for updating a react-native documentation (added a new file "Packaging an iOS component ") in guides(ios) -> Packaging an iOS component

@ghost

ghost commented May 2, 2016

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @bestander and @sebmarkbage to be potential reviewers.

@ghost

ghost commented May 2, 2016

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost

ghost commented May 2, 2016

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2016
@bestander

Copy link
Copy Markdown
Contributor

ping @Kureev @grabbou

Comment thread docs/packaging-a-RNComponent-ios.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduction is great, but I'd suggest splitting it into smaller sentences to make it easier to read, what do you think?

@grabbou

grabbou commented May 3, 2016

Copy link
Copy Markdown
Contributor

Looks good! I left few comments & questions. I am by no means an english expert, but what I find helpful is the http://www.hemingwayapp.com/ app - will highlight tricky sentences and constructs that are hard to read. Might be useful if you want to play around :)

@grabbou

grabbou commented May 3, 2016 •

Copy link
Copy Markdown
Contributor

@bestander on that note, shouldn't cli be able to scaffold an empty plugin boilerplate? Just like we do init, we could do init-module? I have a boilerplate internally that I am using in every project, might submit a PR with it as a companion to this docs.

@bestander

Copy link
Copy Markdown
Contributor

@bestander on that note, shouldn't cli be able to scaffold an empty plugin boilerplate? Just like we do init, we could do init-module? I have a boilerplate internally that I am using in every project, might submit a PR with it as a companion to this docs.

It all depends.
If it itches then scratch it :)

@ghost

ghost commented Jun 1, 2016

Copy link
Copy Markdown

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @bestander as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed and removed GH Review: needs-revision labels Jul 12, 2016
@Hari70a

Hari70a commented Jul 13, 2016

Copy link
Copy Markdown
Author

I have committed the changes suggested by you (cc:@bestander @Kureev and @grabbou). Please share your thoughts.

Comment thread docs/CommunicationIOS.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use lower case for these links.
Also RN is not needed because everything here is RN.
How about packaging-ios-component?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @bestander I will do it

@bestander

Copy link
Copy Markdown
Contributor

cc @JoelMarcey, how does it fit our docs work?

@Hari70a Hari70a changed the title Packaging a react native component file added Packaging a react native component Jul 13, 2016
@Hari70a Hari70a changed the title Packaging a react native component Packaging a react native(ios) component Jul 13, 2016
@ghost

ghost commented Jul 29, 2016

Copy link
Copy Markdown

@Hari70a updated the pull request.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2016
@JoelMarcey

Copy link
Copy Markdown

@Hari70a Did you add new commits? I don't see them here. Or did the bot just go a bit crazy?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2016
@Hari70a

Hari70a commented Aug 1, 2016

Copy link
Copy Markdown
Author

@JoelMarcey Actually I have rebased my cloned master to the repo's latest master . I am facing some issues while running locally ReferenceError: Unknown plugin "transform-flow-strip-types" specified in "base" at 0, attempted to resolve relative to "."

That's why I was unable to do my commits..

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2016
@bestander

Copy link
Copy Markdown
Contributor

ReferenceError: Unknown plugin "transform-flow-strip-types" specified in "base" at 0, attempted to resolve relative to "."

This thing can happen if you run packager from a wrong folder.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @ramirogm as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2016
@bestander

Copy link
Copy Markdown
Contributor

@Hari70a, anything blocks you here?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2016
@hramos

hramos commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

@Hari70a still planning to ship this?


* Push to Github, publish on npm `git push origin head --tags && npm publish` (if you haven't published a npm module before, [check this out](https://gist.github.com/coolaj86/1318304)).

Great! You now have a package that can be used publicly by calling `npm install your-best-package-name`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra spaces

@mkonicek

mkonicek commented Nov 23, 2016 •

Copy link
Copy Markdown
Contributor

I vote we document this instead: https://github.com/frostney/react-native-create-library. The tool should automate a lot of the manual work. We should probably integrate it directly into the RN CLI.

@grabbou

grabbou commented Nov 25, 2016

Copy link
Copy Markdown
Contributor

@mkonicek on that note, I could PR to react-native-create-library so that it works as a plugin (before we try to merge it). I am opening an issue in the library :)

@lacker

lacker commented Dec 15, 2016

Copy link
Copy Markdown
Contributor

I agree with @mkonicek - we should encourage some external tooling like react-native-create-library instead. @lelandrichardson also expressed some interest in working on a tool here. I'm going to close this pull request but thanks everyone for helping out!

@lacker lacker closed this Dec 15, 2016
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Something went wrong executing that command, @mkonicek could you take a look?

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Something went wrong executing that command, @mkonicek could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants