Repository navigation
Conversation
|
By analyzing the blame information on this pull request, we identified @bestander and @sebmarkbage to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
This introduction is great, but I'd suggest splitting it into smaller sentences to make it easier to read, what do you think?
|
Looks good! I left few comments & questions. I am by no means an english expert, but what I find helpful is the http://www.hemingwayapp.com/ app - will highlight tricky sentences and constructs that are hard to read. Might be useful if you want to play around :) |
|
@bestander on that note, shouldn't |
It all depends. |
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @bestander as a potential reviewer. Could you take a look please or cc someone with more context? |
|
I have committed the changes suggested by you (cc:@bestander @Kureev and @grabbou). Please share your thoughts. |
There was a problem hiding this comment.
We use lower case for these links.
Also RN is not needed because everything here is RN.
How about packaging-ios-component?
|
cc @JoelMarcey, how does it fit our docs work? |
|
@Hari70a updated the pull request. |
|
@Hari70a Did you add new commits? I don't see them here. Or did the bot just go a bit crazy? |
|
@JoelMarcey Actually I have rebased my cloned master to the repo's latest master . I am facing some issues while running locally ReferenceError: Unknown plugin "transform-flow-strip-types" specified in "base" at 0, attempted to resolve relative to "." That's why I was unable to do my commits.. |
This thing can happen if you run packager from a wrong folder. |
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @ramirogm as a potential reviewer. Could you take a look please or cc someone with more context? |
|
@Hari70a, anything blocks you here? |
|
@Hari70a still planning to ship this? |
|
|
||
| * Push to Github, publish on npm `git push origin head --tags && npm publish` (if you haven't published a npm module before, [check this out](https://gist.github.com/coolaj86/1318304)). | ||
|
|
||
| Great! You now have a package that can be used publicly by calling `npm install your-best-package-name` |
|
I vote we document this instead: https://github.com/frostney/react-native-create-library. The tool should automate a lot of the manual work. We should probably integrate it directly into the RN CLI. |
|
@mkonicek on that note, I could PR to react-native-create-library so that it works as a plugin (before we try to merge it). I am opening an issue in the library :) |
|
I agree with @mkonicek - we should encourage some external tooling like react-native-create-library instead. @lelandrichardson also expressed some interest in working on a tool here. I'm going to close this pull request but thanks everyone for helping out! |
|
Something went wrong executing that command, @mkonicek could you take a look? |
|
Something went wrong executing that command, @mkonicek could you take a look? |
Here I have submitted a pull request for updating a react-native documentation (added a new file "Packaging an iOS component ") in guides(ios) -> Packaging an iOS component