Repository navigation
Fix regression in API impacting Codespaces - #2978
Merged
datho7561 merged 1 commit intoMar 2, 2023
Merged
Conversation
The API wouldn't report lightweight mode correctly when it was forced to start in lightweight due to vscode-java detecting it was being run in Codespaces. This broke the mechanism to switch to standard mode in Codespaces. Fixes redhat-developer#2968 Signed-off-by: David Thompson <davthomp@redhat.com>
Contributor
Author
|
To test this PR:
|
rgrunber
approved these changes
Mar 2, 2023
rgrunber
left a comment
rgrunber
left a comment
Member
There was a problem hiding this comment.
Looks like this is just restoring tbe part of https://github.com/redhat-developer/vscode-java/pull/2905/files#diff-04bba6a35cad1c794cbbe677678a51de13441b7a6ee8592b7b50be1f05c6f626L375-L378 that updated the server mode.
Feel free to merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API wouldn't report lightweight mode correctly when it was forced to start in lightweight due to vscode-java detecting it was being run in Codespaces. This broke the mechanism to switch to standard mode in Codespaces.
Fixes #2968
Signed-off-by: David Thompson davthomp@redhat.com