Repository navigation
Parser leading attr strictness - #7787
Merged
Merged
Conversation
zth
force-pushed
the
parser-leading-attr-strictness
branch
from
August 22, 2025 09:24
c91ae80 to
01158eb
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cristianoc
approved these changes
Aug 23, 2025
cristianoc
left a comment
cristianoc
left a comment
Collaborator
There was a problem hiding this comment.
Looks great.
Just some comments on code duplication.
| | Lbrace -> | ||
| (* consume the attributes and any doc comments before the record *) | ||
| ignore (parse_attributes p); | ||
| let rec skip_docs () = |
Collaborator
There was a problem hiding this comment.
Same fun defined a few lines above.
| | DotDot -> | ||
| (* attributes before an open variant marker; consume attrs/docs then handle `..` *) | ||
| ignore (parse_attributes p); | ||
| let rec skip_docs () = |
| Parser.lookahead p (fun state -> | ||
| ignore (parse_attributes state); | ||
| (* optionally skip a run of doc comments before deciding *) | ||
| let rec skip_docs () = |
| x: int ; | ||
| y: int } No newline at end of file | ||
| y: int } | ||
| type nonrec t = { |
Collaborator
There was a problem hiding this comment.
The printer will also need attention. Perhaps for later and one can just add the issue for now.
zth
force-pushed
the
parser-leading-attr-strictness
branch
from
August 23, 2025 18:48
01158eb to
4329600
Compare
zth
enabled auto-merge (squash)
August 23, 2025 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #7782.