Repository navigation
Conversation
Add EMAIL_FONTS (web-safe stacks plus Inter, Roboto, Open Sans, Lato), a fontFamily theme property and a Font input in the basic text panel. The body font is repeated on the container table for Outlook, and web fonts used by the theme or a fontFamily mark get a stylesheet link in <head>. Also fix ThemeConfig body overrides landing in a duplicate input when the property lives in the typography group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ThnJ4Yz175LLQEJnjvNtzY
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: e48c6d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Collect fontFamily from every merged theme component, not only the body, so a web font configured on a heading or other component gets its stylesheet link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ThnJ4Yz175LLQEJnjvNtzY
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: The font picker is bounded, but using web fonts adds Google Fonts requests to recipient emails and may render differently across clients. Human review should approve that privacy and compatibility tradeoff.
View guided diff | Re-trigger cubic
Keep only web-safe font stacks so emails and the editor load nothing from fonts.googleapis.com, and remove the web font <link> emission. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ThnJ4Yz175LLQEJnjvNtzY
klotty
left a comment
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds email-safe font choices and a Font select to the editor theme, repeats the body font on the container for Outlook, and fixes ThemeConfig body overrides. Web-font loading was dropped, removing the external-request and client-rendering risks.
View guided diff | Re-trigger cubic
Adds email-safe font families to the editor theme, as the base for a font picker in the Resend broadcast editor. resend/resend-monorepo#14764 already uses this branch's build through a pnpm patch.
What changes
EMAIL_FONTS(exported from@react-email/editor/plugins): web-safe font stacks only.fonts.googleapis.com.fontFamilytheme property: it is now aKnownCssProperties/SUPPORTED_CSS_PROPERTIESselect. The basic theme's Text panel has a "Font" input onbody.<body>font into tables.ThemeConfigoverrides: a{ body: { fontFamily } }override used to be added as a duplicate input in thebodygroup, where thetypographygroup's input overwrote it. The lookup now searches every group, which also fixesbody.fontSizeoverrides.The 4 updated
container.spec.tsxsnapshots only gain thefont-familyon the container table.Checks
vitest --project unit: 555 pass, includingfonts.spec.tsx.tsc --noEmitandbiome checkare clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01ThnJ4Yz175LLQEJnjvNtzY