Skip to content

fix: type issues - #585

Merged
gabrielmfern merged 2 commits into
canaryfrom
fix/type-issues
Aug 22, 2025
Merged

gabrielmfern merged 2 commits into
canaryfrom
fix/type-issues

Conversation

@gabrielmfern

@gabrielmfern gabrielmfern commented Aug 21, 2025 •

Copy link
Copy Markdown
Member

Fix some type issues introduced in #580. Also, changes the tsconfig.json slightly so we can check that our types are fine by running pnpm tsc.


Summary by cubic

Fixes type issues from #580 by switching the test fetch mock to vitest-fetch-mock’s MockParams and simplifying headers typing. Updates tsconfig to run tsc in type-check-only mode (noEmit), so pnpm tsc validates types without emitting files.

@gabrielmfern gabrielmfern self-assigned this Aug 21, 2025
@gabrielmfern
gabrielmfern requested a review from a team as a code owner August 21, 2025 20:31
@gabrielmfern
gabrielmfern requested review from felipevolpone and rehanvdm and removed request for rehanvdm August 21, 2025 20:31

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Comment thread src/test-utils/mock-fetch.ts Resolved
@gabrielmfern
gabrielmfern merged commit cb55cc5 into canary Aug 22, 2025
@gabrielmfern
gabrielmfern deleted the fix/type-issues branch August 22, 2025 12:12
gabrielmfern added a commit that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants