Skip to content

Allow selecting the DS closing-lid skin - #575

Open
harshulkuhar wants to merge 1 commit into
rileytestut:mainfrom
harshulkuhar:feat/select-ds-closing-lid-skin
Open

harshulkuhar wants to merge 1 commit into
rileytestut:mainfrom
harshulkuhar:feat/select-ds-closing-lid-skin

Conversation

@harshulkuhar

@harshulkuhar harshulkuhar commented Oct 29, 2026 •

Copy link
Copy Markdown
  • Experimental feature
  • Bug fix

Description

Add a Closed Lid choice to Nintendo DS controller skin settings on iPhone Duo, behind the Custom DS Lid Skins experimental feature.

Reuse the existing .deltaskin importer, database, preview list, reset action, and preferred-controller-skin storage. Render the selected skin's existing .cover representation when closing the device. Cover selection is system-wide.

Cover traits have no stored configuration flag, so the picker filters imported DS skins by their actual .cover support. No database migration, new skin format, custom image importer, or bundled artwork is added. Folding and sleep behavior are unchanged.

Testing

  • Xcode 27.1, iOS 27.1 SDK: unsigned Release arm64 iPhone build succeeded with BETA enabled.
  • git diff --check passed.
  • Device testing by the contributor: iPhone Duo, iOS 27.2. Importing a .deltaskin, selecting the closing-lid skin, resetting to default, and closing/reopening the device all passed.

Checklist

General (All PRs)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I've tested my changes with different device + OS version configurations

Experimental Feature-specific

  • Added property to ExperimentalFeatures struct annotated with @Feature
  • Uses @Option's to persist all feature-related data — reuses the existing controller skin preference instead of adding separate feature state
  • Locked all behavior changes behind ExperimentalFeatures.shared.customDSLidSkins.isEnabled
  • Isolates changes as much as possible — four existing Swift files; no new implementation files

@harshulkuhar
harshulkuhar marked this pull request as ready for review October 29, 2026 18:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant