Repository navigation
Allow selecting the DS closing-lid skin - #575
Open
harshulkuhar wants to merge 1 commit into
Open
harshulkuhar wants to merge 1 commit into
harshulkuhar wants to merge 1 commit into
Conversation
harshulkuhar
marked this pull request as ready for review
October 29, 2026 18:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Closed Lid choice to Nintendo DS controller skin settings on iPhone Duo, behind the Custom DS Lid Skins experimental feature.
Reuse the existing
.deltaskinimporter, database, preview list, reset action, and preferred-controller-skin storage. Render the selected skin's existing.coverrepresentation when closing the device. Cover selection is system-wide.Cover traits have no stored configuration flag, so the picker filters imported DS skins by their actual
.coversupport. No database migration, new skin format, custom image importer, or bundled artwork is added. Folding and sleep behavior are unchanged.Testing
git diff --checkpassed..deltaskin, selecting the closing-lid skin, resetting to default, and closing/reopening the device all passed.Checklist
General (All PRs)
Experimental Feature-specific
ExperimentalFeaturesstruct annotated with@Feature@Option's to persist all feature-related data — reuses the existing controller skin preference instead of adding separate feature stateExperimentalFeatures.shared.customDSLidSkins.isEnabled