Repository navigation
Add experimental screen orientation setting for iPhone - #581
Open
JaeyeongYang wants to merge 1 commit into
Open
JaeyeongYang wants to merge 1 commit into
JaeyeongYang wants to merge 1 commit into
Conversation
JaeyeongYang
force-pushed
the
feature-screen-orientation
branch
from
November 17, 2026 05:40
5b8781c to
0b6ff1e
Compare
JaeyeongYang
force-pushed
the
feature-screen-orientation
branch
from
November 17, 2026 06:09
0b6ff1e to
df890bc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the type contribution you are making:
Description
Summary of your changes, including:
Why is this change necessary?
Delta rotates with the device, but it has no in-app setting to choose and keep a specific orientation. I wanted to keep the screen in portrait or either landscape direction without having to hold the phone in that position.
Why did you decide on this solution?
A single app-wide setting keeps the selected orientation consistent across the game library, settings, and game scenes. Using the existing
@Featureand@Optionsystem makes it opt-in and saves the choice through the app's existing settings mechanism. The feature is disabled by default; Automatic mode and disabling it preserve the existing rotation behavior.This adds a Screen Orientation experimental feature for iPhone with four options: Automatic, Portrait, Landscape Left, and Landscape Right.
System image and document pickers retain the orientations they need, with the selected orientation policy restored when they close. External displays keep their existing behavior.
In iPad simulator testing, UIKit rejected fixed-orientation requests under Delta's current multitasking configuration, even when the app filled the screen. A separate test app could rotate with
UIRequiresFullScreenenabled, but applying that setting to Delta would change its multitasking support. This PR leaves that broader app policy unchanged and labels the feature as iPhone-only.The project file only registers the new Swift source; deployment targets, dependency lockfiles, and submodules are unchanged.
Testing
Checklist
General (All PRs)
Experimental Feature-specific
ExperimentalFeaturesstruct annotated with@Feature@Option's to persist all feature-related dataExperimentalFeatures.shared.[feature].isEnabledruntime check