Repository navigation
Conversation
Noticed while running the Ruby specs manually today that a ton of
warning output's snuck in since the full River implementation came in,
and from a variety of sources. Here, get rid of it all:
* **Updated SimpleCov configuration:** Replace deprecated `add_filter`
calls with `skip`.
* **Isolated fork tests:** Configuration tests were previously forking
the entire RSpec process including SQLite connections opened by the
parent. SQLite warned as it discarded those. Here, start a fresh Ruby
process before forking.
* **Capture Postgres notices:** The reconnection test deliberately
terminated its listener connection, causing libpq to print:
FATAL: terminating connection due to administrator command
It still does, but now we capture the notice.
* **Quieted Rails generator:** The spec ran the Rails generator,
producing some natural output into the stream. We now run the
generator with `--quiet` so it suppresses its own messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while running the Ruby specs manually today that a ton of
warning output's snuck in since the full River implementation came in,
and from a variety of sources. Here, get rid of it all:
Updated SimpleCov configuration: Replace deprecated
add_filtercalls with
skip.Isolated fork tests: Configuration tests were previously forking
the entire RSpec process including SQLite connections opened by the
parent. SQLite warned as it discarded those. Here, start a fresh Ruby
process before forking.
Capture Postgres notices: The reconnection test deliberately
terminated its listener connection, causing libpq to print:
It still does, but now we capture the notice.
Quieted Rails generator: The spec ran the Rails generator,
producing some natural output into the stream. We now run the
generator with
--quietso it suppresses its own messages.