Repository navigation
Snapshot mutable property values when saving filter history - #346
Open
xixihaha-ha wants to merge 1 commit into
Open
xixihaha-ha wants to merge 1 commit into
xixihaha-ha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saver.savecopies ordinary instance attributes but appends property values by reference. If a property exposes a mutable array or nested container, subsequent filter updates silently rewrite previously saved history.Deep-copy property values when taking each snapshot, consistently with the existing attribute snapshots. Tests exercise in-place array updates, nested-list mutations, independence between snapshots and the live model, and ignored properties.
Validation: the history regression fails on unchanged main and passes with the fix. The full common helper/discretization tests report 16 passed (Python 3.11 / NumPy 1.26).
AI assistance was used to investigate, implement and test this change.