Repository navigation
asn1: handle GENERALIZEDTIME without seconds - #88
Merged
Merged
Conversation
Member
|
Thanks for the PR! Indeed, X.680 specifies that the seconds part can be absent. The asn1time_to_time() function also does not handle {UTC,Generalized}Time with fraction seconds or time zones, but this would be out of scope of this PR. Could you add some basic tests to test/test_asn1.rb, and update the commit message to include the rationale about the change before merge? |
Author
|
@rhenium ping :-) |
Member
|
@yogo1212 Nice, thanks! Could you squash the third commit into the first one? |
Author
|
nothing comes more naturally than changing the course of history in the past :-D |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encountered this error using a certificate that is accepted by other clients:
this is from asn1parse: