Repository navigation
Open
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustA-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
We should build ALL Rust code in this repo when we do in CI. Including subtrees. This is needed to ensure that contributors will not occasionally break anything, especially when doing tree-wide changes../x test
For example, in #134420 a contributor replaced tree-wide &PathBuf with &Path. Unfortunately, he broke ./x perf. This was not noticed, because src/tools/rustc-perf-wrapper is not built during CI. (Later he fixed that problem.)./x test
So, please, build everything in CI, including subtrees../x test
I add "contributor roadblock", because I think this is minor contributor roadblock.
@rustbot label A-contributor-roadblock C-enhancement -C-bug
HEAD
Metadata
Metadata
Assignees
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustA-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Activity
onur-ozkan commentedon Feb 2, 2025
We can't compile all Rust code with the
x testcommand because some dependencies are gated byconfig.tomland the host machine, but we can definitely extend the scope ofx testcompilation.cuviper commentedon Feb 4, 2025
For downstream builds, I appreciate that the current
x testcovers pretty much what I'm going to ship, whereas stuff like perf is not really relevant. If the defaultx testgrew, then it would be annoying to manually enumerate all the things it used to cover.So maybe there should be a broader pseudo-target for those that want more, like
x test all, or maybe the other way with some name that means the smaller set it used to test. Or maybe there could be a config with different defaults between profiles.[-]We should build ALL Rust code in this repo when we do ./x test[/-][+]We should build ALL Rust code in this repo in CI[/+]safinaskar commentedon Feb 4, 2025
@cuviper , what I really meant is "to build all code in CI". I updated my post and title