Repository navigation
Description
The file should contain data about:
- Native libraries bundled into the rlib, to avoid looking up native libraries during the regular "early" metadata construction, when it's unnecessary and cannot be done fully correctly (native_libs: More consistent native library search between rustc and linker #138170)
- Object files bundled into the rlib, to support link time
cfgon native libraries bundled as object files - Rust object files in the rlib to avoid hacks like
looks_like_rust_object_fileduring LTO
Unlike regular metadata which is constructed early, this additional digest will be constructed and added to the archive in the very end, when all other members of the rlib archive are already added.
It is also going to be read only when rustc is going to link the rlib into something, not earlier.
The data could potentially use some text format like json, but it would probably be simpler to just use the same format as the regular metadata uses.
The implementation can also mirror what is done for regular metadata, in a simplified form.
Me and @belovdv wanted to do this when implementing +bundle,+whole-archive (#113301) and packed_bundled_libs (#108081), as a more principle solution, but ended up with just some workarounds instead, and never returned to this.
Activity
petrochenkov commentedon Mar 8, 2025
I suggest first adding some data that is enough to avoid the file skipping hacks in
fn link_staticlib.bjorn3 commentedon Mar 12, 2025
Why put it at the end? That would mean we have to scan over each rlib twice during linking. Once to find the "digest" and a second time to copy the actual content. Ar archives don't allow random access. You need to iterate over them one entry at a time. Wouldn't it be possible to create this "digest" during rlib writing before adding object files, but after we already know which object files will be added?
petrochenkov commentedon Mar 12, 2025
fn link_rlibcontains a number ofarchive_builder.add_file(...);steps.I assumed each of them would also add something into the digest, then the digest would become ready in the end.
Of course it can be refactored to be a bit smarter as an optimization.
davidtwco commentedon Mar 18, 2025
You might get more visibility on this as an MCP - it sounds reasonable to me.
Rollup merge of rust-lang#154861 - mehdiakiki:fix/rlib-digest, r=petr…
Auto merge of #154861 - mehdiakiki:fix/rlib-digest, r=petrochenkov
Auto merge of #154861 - mehdiakiki:fix/rlib-digest, r=petrochenkov
11 remaining items
Rollup merge of rust-lang#156735 - mehdiakiki:fix/rlib-digest, r=petr…
Rollup merge of rust-lang#156735 - mehdiakiki:fix/rlib-digest, r=petr…
Rollup merge of rust-lang#156735 - mehdiakiki:fix/rlib-digest, r=petr…
Rollup merge of rust-lang#156735 - mehdiakiki:fix/rlib-digest, r=petr…
Rollup merge of rust-lang#156735 - mehdiakiki:fix/rlib-digest, r=petr…
Rollup merge of rust-lang#156735 - mehdiakiki:fix/rlib-digest, r=petr…
Rollup merge of rust-lang#156735 - mehdiakiki:fix/rlib-digest, r=petr…
Unrolled build for #156735
Rollup merge of #156735 - mehdiakiki:fix/rlib-digest, r=petrochenkov
Rollup merge of #158194 - mehdiakiki:rlib-link-meta-cache, r=petroche…
Rollup merge of rust-lang#160272 - petrochenkov:metamove, r=nnethercote
Rollup merge of rust-lang#160272 - petrochenkov:metamove, r=nnethercote
Unrolled build for #160272
Rollup merge of #160272 - petrochenkov:metamove, r=nnethercote
Auto merge of #154861 - mehdiakiki:fix/rlib-digest, r=petrochenkov