You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Attribute representation change in rustdoc JSON without version bump #140689
At a glance, this may have been due to #140606. It may be sufficient to strip the trailing whitespace at the time rustdoc JSON is created to recover the original behavior.
Short term, we can strip white space inside librustdoc, and get the old behaviour. I’ve got a patch locally that does this, I’ll make a PR once i describe it. It might still be worth bumping the format version, as v45 output might be buggy, but v46 output is good (even if v45 from before #140606 is the same as v45).
Longer term, I’d like to make this less likely to happen again. We should probably add a triage or message on changes to tests/rustdoc-json informing PR authors/reviewers to be careful as this is a public API, and that if they want to change it, the FORMAT_VERSION also needs to be bumped. Not sure exactly what would be most useful to say here. CC @nnethercote@dtolnay, what would have been useful to see when reviewing #140606?
It should get an autoreview like what we do for Cargo.lock: #140535 (comment)
Alona was pinged on the broken PR in #140606 (comment). But this comment is not enough for nnethercote or I to know what the review obligation is. Is there a bigger group to ping that would be more likely to intercept bad changes before landing? Some teams / working groups like clippy, miri, rust-analyzer, gcc, trait solver, and some other projects mention the team like this: #126893 (comment)
I would recommend trying with just a more explanatory autoreview comment and see whether it gets improperly ignored.
Not a rustdoc reviewer, but I'm happy to be pinged and participate if that's helpful — I've written parts of the rustdoc json test suite and I'm most likely to be downstream of breakage in it.
Opened #140762 for the format change, and #140773 for more pings and a message in triagebot.
Is there a bigger group to ping that would be more likely to intercept bad changes before landing?
I don't think so. Pinging all of T-Rustdoc seems excessive, as most of them don't work on rustdoc-json. I'll bring it up in the next T-Rustdoc meeting. Predrag offering to get pinged should be helpful though.
Activity
obi1kenobi commentedon May 6, 2025
@rustbot label +A-rustdoc-json +T-compiler
aDotInTheVoid commentedon May 6, 2025
Short term, we can strip white space inside librustdoc, and get the old behaviour. I’ve got a patch locally that does this, I’ll make a PR once i describe it. It might still be worth bumping the format version, as v45 output might be buggy, but v46 output is good (even if v45 from before #140606 is the same as v45).
Longer term, I’d like to make this less likely to happen again. We should probably add a triage or message on changes to
tests/rustdoc-jsoninforming PR authors/reviewers to be careful as this is a public API, and that if they want to change it, the FORMAT_VERSION also needs to be bumped. Not sure exactly what would be most useful to say here. CC @nnethercote @dtolnay, what would have been useful to see when reviewing #140606?dtolnay commentedon May 6, 2025
It should get an autoreview like what we do for Cargo.lock: #140535 (comment)
Alona was pinged on the broken PR in #140606 (comment). But this comment is not enough for nnethercote or I to know what the review obligation is. Is there a bigger group to ping that would be more likely to intercept bad changes before landing? Some teams / working groups like clippy, miri, rust-analyzer, gcc, trait solver, and some other projects mention the team like this: #126893 (comment)
I would recommend trying with just a more explanatory autoreview comment and see whether it gets improperly ignored.
obi1kenobi commentedon May 6, 2025
Not a rustdoc reviewer, but I'm happy to be pinged and participate if that's helpful — I've written parts of the rustdoc json test suite and I'm most likely to be downstream of breakage in it.
aDotInTheVoid commentedon May 7, 2025
Opened #140762 for the format change, and #140773 for more pings and a message in triagebot.
I don't think so. Pinging all of T-Rustdoc seems excessive, as most of them don't work on rustdoc-json. I'll bring it up in the next T-Rustdoc meeting. Predrag offering to get pinged should be helpful though.
Rollup merge of rust-lang#140762 - aDotInTheVoid:popnl, r=GuillaumeGomez
Rollup merge of rust-lang#140773 - aDotInTheVoid:rdj-triagdfsadgs, r=…
Rollup merge of rust-lang#140762 - aDotInTheVoid:popnl, r=GuillaumeGomez
Rollup merge of rust-lang#140773 - aDotInTheVoid:rdj-triagdfsadgs, r=…
Unrolled build for rust-lang#140773
Unrolled build for rust-lang#140762