You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
unused_braces warning emitted for braces that have semantic value #154247
Since the adoption of tail expression temporary scope changes in the 2024 edition, it is safe to wrap a method call on a temporary lock guard in a block with assurance that the lock will be dropped before exiting the scope. It seems like this lint is either being emitted in error (false positive) or the other, very similar expression in the same file is not being detected (false negative).
Lint Name
unused_braces
Reproducer
Diagnostic emitted by rustc:
warning: unnecessary braces around method argument
--> .../file.rs:459:29
|
459 | self.update({ self.lockable.lock().do_work()?.collect() })
| ^^ ^^
|
= note: `#[warn(unused_braces)]` on by default
help: remove these braces
|
459 - self.update({ self.lockable.lock().do_work()?.collect() })
459 + self.update(self.lockable.lock().do_work()?.collect())
There's a similar implementation in an impl block right below this that does not have this lint emitted
unused_braces is a lint emitted by the compiler, not Clippy (Clippy lints are prefixed with clippy::). You are likely encountering the same warning when running cargo check or cargo build.
Activity
samueltardieu commentedon Mar 23, 2026
unused_bracesis a lint emitted by the compiler, not Clippy (Clippy lints are prefixed withclippy::). You are likely encountering the same warning when runningcargo checkorcargo build.@rustbot transfer rust
Rollup merge of rust-lang#154373 - chenyukang:yukang-fix-154247-unuse…
Rollup merge of rust-lang#154373 - chenyukang:yukang-fix-154247-unuse…
Rollup merge of rust-lang#154373 - chenyukang:yukang-fix-154247-unuse…
Rollup merge of rust-lang#154373 - chenyukang:yukang-fix-154247-unuse…
Rollup merge of rust-lang#154373 - chenyukang:yukang-fix-154247-unuse…
Rollup merge of rust-lang#154373 - chenyukang:yukang-fix-154247-unuse…
Unrolled build for #154373 in rollup 162631