Skip to content

Visitor glue regressed rustc performance by 8 seconds #2558

Closed
MarcelRaschke/rust
#6

Description

@pcwalton

Are we not generating it lazily?

Activity

  1. pcwalton commented on Jun 9, 2012

    @pcwalton
    ContributorAuthor
  2. ghost assigned on Jun 14, 2012
  3. graydon commented on Jun 21, 2012

    @graydon
    Contributor

    Lazily, yes, but it's generated for anything that has a full tydesc instantiated, which is a lot of them. Anything boxed, say.

  4. graydon commented on Aug 29, 2012

    @graydon
    Contributor

    I don't think there's a bug here to be fixed, since we're going to continue generating this code. If it turns out to be hot in profiles we'll spend time optimizing it like anything else, but otherwise the feature's not backing out, so.. closing. LMK if you think this is wrong.

  5. added a commit that references this issue on Sep 23, 2022
  6. added a commit that references this issue on Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-codegenArea: Code generationI-slowIssue: Problems and improvements with respect to performance of generated code.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions