Skip to content

Tracking issue for custom_derive feature #29644

Closed

Description

@aturon

Treats #[derive(Anything)] like #[derive_Anything]. Tracking for stabilization.

Activity

  1. added
    T-langRelevant to the language team
    B-unstableBlocker: Implemented in the nightly compiler and unstable.
    on Nov 5, 2015
  2. eefriedman commented on Nov 10, 2015

    @eefriedman
    Contributor

    There isn't really much incentive to stabilize this at the moment; this is basically only useful with plugins (and syntex, but the gate doesn't affect that usage).

  3. nrc commented on Mar 31, 2016

    @nrc
    Member

    Is there an RFC for this? I couldn't find one easily.

  4. eefriedman commented on Mar 31, 2016

    @eefriedman
    Contributor

    No RFC; see #23137.

  5. nrc commented on Mar 31, 2016

    @nrc
    Member

    Do we know who uses custom_derive? It seems like a horrible hack.

    (Thanks for the link @eefriedman)

  6. pnkfelix commented on Mar 31, 2016

    @pnkfelix
    Contributor

    wow look at the turnaround time on that PR! Proposed, r+'ed, and landed all in one day!

  7. jimmycuadra commented on Mar 31, 2016

    @jimmycuadra
    Contributor

    Two crates that use custom_derive: serde_macros and diesel_codegen.

  8. eefriedman commented on Mar 31, 2016

    @eefriedman
    Contributor

    Servo also uses it in a few places, for example https://github.com/servo/heapsize .

  9. nrc commented on Mar 31, 2016

    @nrc
    Member

    Thanks for the info. I think custom derive is something we should support, but not in the current form. I'll have a think about how it fits in to the procedural macro overhaul and write some kind of RFC.

  10. e-oz commented on Jun 29, 2016

    @e-oz

    HOPE WILL NEVER DIE!

    Can't use XML/JSON deserialization to structures, but I still hope...

    😢

  11. nrc commented on Aug 29, 2016

    @nrc
    Member
  12. nrc commented on Sep 27, 2016

    @nrc
    Member

    Nominating for deprecation now that we have macros 1.1 custom derive in place.

  13. 21 remaining items

  14. e-oz commented on Feb 2, 2017

    @e-oz

    I have to say it was awful idea to release new feature with exactly same name as old deprecated feature.

  15. jseyfried commented on Feb 2, 2017

    @jseyfried
    Contributor

    The name of the new feature was proc_macro, or macros 1.1. Both the old feature and the new feature allow defining and using custom derives.

  16. jseyfried commented on Feb 2, 2017

    @jseyfried
    Contributor

    Of course, in retrospect it would have been better to name the old feature something more specific than custom_derive.

  17. aturon commented on Feb 2, 2017

    @aturon
    ContributorAuthor

    I think the complaint was about the release announcement, which said we're stabilizing "custom derive". I agree that this is all a bit confusing, especially for those not following Rust development closely.

  18. e-oz commented on Feb 2, 2017

    @e-oz

    Yes, that's what broke my whole app and gave me work for a couple of next days.

  19. added
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Jul 22, 2017
  20. cramertj commented on Jan 17, 2018

    @cramertj
    Member

    @SergioBenitez Are you still using this feature?

  21. SergioBenitez commented on Jan 19, 2018

    @SergioBenitez
    Contributor

    @cramertj Yes. With the recent improvements to the proc_macro APIs and a few additional ones, however, I should be able to move Rocket to proc_macro soon.

  22. fbstj commented on Jul 16, 2018

    @fbstj
    Contributor

    @SergioBenitez are you still using this feature?

  23. SergioBenitez commented on Jul 16, 2018

    @SergioBenitez
    Contributor

    Yes. The plan is to migrate away from custom_derive as soon as possible however. Current progress puts us as doing so by next release, or about a month.

  24. SergioBenitez commented on Sep 17, 2018

    @SergioBenitez
    Contributor

    Update: All of Rocket's derives are now implemented as proc-macros and will ship as such in the next official release, which should be within a couple of weeks time.

  25. added a commit that references this issue on Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-langRelevant to the language team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions