You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There isn't really much incentive to stabilize this at the moment; this is basically only useful with plugins (and syntex, but the gate doesn't affect that usage).
Thanks for the info. I think custom derive is something we should support, but not in the current form. I'll have a think about how it fits in to the procedural macro overhaul and write some kind of RFC.
I think the complaint was about the release announcement, which said we're stabilizing "custom derive". I agree that this is all a bit confusing, especially for those not following Rust development closely.
Reacted by Flaise, Sam Whited, Paul Ellenbogen and L-as
@cramertj Yes. With the recent improvements to the proc_macro APIs and a few additional ones, however, I should be able to move Rocket to proc_macro soon.
Reacted by Dan (Eli) Hastings, TuringZhu, Melanie and Félix
Reacted by Taylor Cramer, hcpl, Melanie and shekohex
Yes. The plan is to migrate away from custom_derive as soon as possible however. Current progress puts us as doing so by next release, or about a month.
Update: All of Rocket's derives are now implemented as proc-macros and will ship as such in the next official release, which should be within a couple of weeks time.
Reacted by Taylor Cramer, Eduard-Mihai Burtescu, shekohex, Hendrik Sollich, L-as, Mazdak Farrokhzad, Félix and Tux3
Activity
eefriedman commentedon Nov 10, 2015
There isn't really much incentive to stabilize this at the moment; this is basically only useful with plugins (and syntex, but the gate doesn't affect that usage).
nrc commentedon Mar 31, 2016
Is there an RFC for this? I couldn't find one easily.
eefriedman commentedon Mar 31, 2016
No RFC; see #23137.
nrc commentedon Mar 31, 2016
Do we know who uses custom_derive? It seems like a horrible hack.
(Thanks for the link @eefriedman)
pnkfelix commentedon Mar 31, 2016
wow look at the turnaround time on that PR! Proposed, r+'ed, and landed all in one day!
jimmycuadra commentedon Mar 31, 2016
Two crates that use custom_derive: serde_macros and diesel_codegen.
eefriedman commentedon Mar 31, 2016
Servo also uses it in a few places, for example https://github.com/servo/heapsize .
nrc commentedon Mar 31, 2016
Thanks for the info. I think custom derive is something we should support, but not in the current form. I'll have a think about how it fits in to the procedural macro overhaul and write some kind of RFC.
Add serde_codegen and build script for stable Rust
Add serde_codegen and build script for stable Rust
e-oz commentedon Jun 29, 2016
HOPE WILL NEVER DIE!
Can't use XML/JSON deserialization to structures, but I still hope...
😢
nrc commentedon Aug 29, 2016
cc #35900
nrc commentedon Sep 27, 2016
Nominating for deprecation now that we have macros 1.1 custom derive in place.
21 remaining items
e-oz commentedon Feb 2, 2017
I have to say it was awful idea to release new feature with exactly same name as old deprecated feature.
jseyfried commentedon Feb 2, 2017
The name of the new feature was
proc_macro, or macros 1.1. Both the old feature and the new feature allow defining and using custom derives.jseyfried commentedon Feb 2, 2017
Of course, in retrospect it would have been better to name the old feature something more specific than
custom_derive.aturon commentedon Feb 2, 2017
I think the complaint was about the release announcement, which said we're stabilizing "custom derive". I agree that this is all a bit confusing, especially for those not following Rust development closely.
e-oz commentedon Feb 2, 2017
Yes, that's what broke my whole app and gave me work for a couple of next days.
cramertj commentedon Jan 17, 2018
@SergioBenitez Are you still using this feature?
SergioBenitez commentedon Jan 19, 2018
@cramertj Yes. With the recent improvements to the proc_macro APIs and a few additional ones, however, I should be able to move Rocket to proc_macro soon.
fbstj commentedon Jul 16, 2018
@SergioBenitez are you still using this feature?
SergioBenitez commentedon Jul 16, 2018
Yes. The plan is to migrate away from custom_derive as soon as possible however. Current progress puts us as doing so by next release, or about a month.
SergioBenitez commentedon Sep 17, 2018
Update: All of Rocket's derives are now implemented as proc-macros and will ship as such in the next official release, which should be within a couple of weeks time.
Auto merge of #54271 - petrochenkov:nolegder, r=eddyb,alexcrichton