Repository navigation
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.O-windowsOperating system: WindowsOperating system: Windows
Description
If you don't have some sort of msys in your PATH, then the libstd process tests will fail because they attempt to spawn programs that don't exist on Windows by default.
failures:
---- process::tests::test_finish_once stdout ----
thread 'process::tests::test_finish_once' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', src\libcore\result.rs:845
---- process::tests::test_finish_twice stdout ----
thread 'process::tests::test_finish_twice' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', src\libcore\result.rs:845
---- process::tests::test_process_output_error stdout ----
thread 'process::tests::test_process_output_error' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', src\libcore\result.rs:845
---- process::tests::test_process_output_output stdout ----
thread 'process::tests::test_process_output_output' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', src\libcore\result.rs:845
---- process::tests::test_process_status stdout ----
thread 'process::tests::test_process_status' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', src\libcore\result.rs:845
---- process::tests::test_wait_with_output_once stdout ----
thread 'process::tests::test_wait_with_output_once' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', src\libcore\result.rs:845
failures:
process::tests::exit_reported_right
process::tests::smoke
process::tests::stdout_works
process::tests::test_finish_once
process::tests::test_finish_twice
process::tests::test_process_output_error
process::tests::test_process_output_output
process::tests::test_process_status
process::tests::test_wait_with_output_once
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.O-windowsOperating system: WindowsOperating system: Windows
Activity
brson commentedon Dec 23, 2016
It's probably best for the test suite to run it's own binaries for testing processes, but in the short term we can just make their names unix/windows-specific.
brson commentedon Dec 23, 2016
The task here should be simple. Identify equivalent windows system exes to call for the failing tests and use cfgs to enable them on windows.
abhijeetbhagat commentedon Dec 23, 2016
i can work on this.
petrochenkov commentedon Dec 28, 2016
All
run-maketests also fail when run without msys (they are not skipped on MSVC, at least in rustbuild).In theory they could use MSVC's
nmakeinstead ofmake, they should be compatible for very simple makefiles.alexcrichton commentedon Dec 28, 2016
@petrochenkov oh my plan with
run-makewas to migrate all the tests to Rust actually one day rather than prolonging the life ofmake. I feel like it'd be a never-ending series of painful PRs to maintain compatibility with bothmakeandnmake, so we could solve both by making a rustbuild-like transition, just rewriting all the tests in Rust.petrochenkov commentedon Mar 7, 2017
Some status update: This is a bad idea.
nmake and gnu make are largely incompatible and most of
src\test\run-make\tools.mkand many makefiles need to be rewritten + run-make tests actively use other unix utilities unavailable in MSVC environment.