Skip to content

Bad error message when using try operator in a closure #46680

Closed

Description

@eira-fransham

Minimal reproduction:

|| {
    Err(())?;
    Ok(())
}

Leads to an error message like:

error[E0282]: type annotations needed
 --> src/main.rs:3:9
  |
3 |         Err(())?;
  |         --------
  |         |
  |         cannot infer type for `_`
  |         in this macro invocation

error: aborting due to previous error

Because ? uses Into and it's ambiguous which type you're converting this error into. Even as a relatively-veteran Rust programmer it still took me some time and playing around before I worked out what was causing this error, I can't imagine how it must be for a new recruit. I think the ideal solution would be to have it default to Into<Self> as long as the error types of all of the expressions ? is used on match, but that would require an RFC and at the bare minimum a more explicit error message could be written for this case.

Activity

  1. added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    A-diagnosticsArea: Messages for errors, warnings, and lints
    A-closuresArea: Closures (`|…| { … }`)
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jan 30, 2018
  2. estebank commented on Aug 12, 2019

    @estebank
    Contributor

    Current output:

    error[E0282]: type annotations needed for `[closure@src/main.rs:3:13: 6:6]`
     --> src/main.rs:4:9
      |
    3 |     let x = || {
      |         - consider giving `x` the explicit type `[closure@src/main.rs:3:13: 6:6]`, with the type parameters specified
    4 |         Err(())?;
      |         ^^^^^^^^ cannot infer type
    
  3. added a commit that references this issue on Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-closuresArea: Closures (`|…| { … }`)A-diagnosticsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions