Repository navigation
Use slice::fill in io::Repeat implementation - #136967
Merged
Merged
Conversation
commented
Feb 13, 2025
Collaborator
joboet
approved these changes
Feb 13, 2025
| } | ||
|
|
||
| // SAFETY: No uninit bytes are being written. | ||
| crate::mem::MaybeUninit::fill(unsafe { buf.as_mut() }, self.byte); |
Member
There was a problem hiding this comment.
I'm not a big fan of long paths... could you use MaybeUninit instead?
Use the existing `fill` methods on slices instead of manually writing the fill loop.
DaniPopes
force-pushed
the
io-repeat-fill
branch
from
February 13, 2025 11:24
757fd7a to
1a3efd2
Compare
commented
Feb 13, 2025
Member
|
Thank you! |
commented
Feb 13, 2025
Collaborator
This was referenced Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the existing
fillmethods on slices instead of manually writing the fill loop.