Repository navigation
Add new target: i686-unknown-none - #160291
Merged
Merged
Conversation
Collaborator
|
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
Member
|
@rustbot reroll |
camelid
reviewed
Aug 6, 2026
Member
|
Unfortunately not the best person to review a new target. @rustbot reroll |
alexhrao
force-pushed
the
i686-unknown-none
branch
from
August 6, 2026 16:33
a20d42f to
b22a68f
Compare
Member
|
r? compiler_leads |
davidtwco
requested changes
Sep 23, 2026
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
alexhrao
commented
Sep 23, 2026
alexhrao
force-pushed
the
i686-unknown-none
branch
from
September 23, 2026 15:42
b22a68f to
43a0762
Compare
Contributor
Author
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
These commits modify compiler targets. |
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
alexhrao
force-pushed
the
i686-unknown-none
branch
from
November 16, 2026 16:51
134ddb4 to
34d188d
Compare
davidtwco
approved these changes
Nov 17, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 17, 2026
…uwer Rollup of 24 pull requests Successful merges: - #164370 (Compact the previous dependency-node reverse index) - #164544 (Add an optional `llvm = ` argument to rustc_intrinsic.) - #165007 (std: Combine `is_mips64_feature_detected` into `is_mips_feature_detected` and enable on MIPS release 6) - #165090 (Check type alignment is <= type size in data layout parser) - #165524 (Cleanup, Get emitting metadata out of codegen) - #165875 (Combine the spans of generic arguments without dropping `->`) - #166074 (rustc: avoid path dependent queries in source presence checks) - #160291 (Add new target: `i686-unknown-none`) - #161708 (hir_typeck: Propagate async closure output into its body) - #162575 (keep the `use<..>` bound in the `refining_impl_trait` suggestion) - #163516 (Update std_detect support for AArch64 Darwin) - #163808 (Add `wasm64-unknown-emscripten` tier 3 target) - #163828 (Change all arm-none targets to skip frame pointers in leaf functions.) - #163966 (Keep deref suggestions from inserting a second pair of brackets) - #164483 (compiler: Add `{x86_64,aarch64}-unknown-serenity` targets) - #164690 (lint: keep type-changing casts in `raw_borrows_via_references`) - #164910 (Add regression tests for #164253) - #164975 (Add wide pointer visualizer for LLDB) - #165652 (Add regression test for GCA associated const with a pattern type field) - #165893 (Prune un/under used methods of `ast::Attribute`) - #166057 ([PAC] Disable rust-tail-cc for pauthtest) - #166071 (illumos dist should enable ThinLTO and codegen-units=1) - #166093 (Move doc attribute and doc comment target checking to attribute parsing) - #166098 (Actually test ABI for C ZSTs and fix Rust ZST ABI for SPARC) Failed merges: - #165267 ([Debuginfo] Emit artificial nested typedef representing generic params on MSVC)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
…uwer Rollup of 24 pull requests Successful merges: - #164370 (Compact the previous dependency-node reverse index) - #164544 (Add an optional `llvm = ` argument to rustc_intrinsic.) - #165007 (std: Combine `is_mips64_feature_detected` into `is_mips_feature_detected` and enable on MIPS release 6) - #165090 (Check type alignment is <= type size in data layout parser) - #165524 (Cleanup, Get emitting metadata out of codegen) - #165875 (Combine the spans of generic arguments without dropping `->`) - #166074 (rustc: avoid path dependent queries in source presence checks) - #160291 (Add new target: `i686-unknown-none`) - #161708 (hir_typeck: Propagate async closure output into its body) - #162575 (keep the `use<..>` bound in the `refining_impl_trait` suggestion) - #163516 (Update std_detect support for AArch64 Darwin) - #163808 (Add `wasm64-unknown-emscripten` tier 3 target) - #163828 (Change all arm-none targets to skip frame pointers in leaf functions.) - #163966 (Keep deref suggestions from inserting a second pair of brackets) - #164483 (compiler: Add `{x86_64,aarch64}-unknown-serenity` targets) - #164690 (lint: keep type-changing casts in `raw_borrows_via_references`) - #164910 (Add regression tests for #164253) - #164975 (Add wide pointer visualizer for LLDB) - #165652 (Add regression test for GCA associated const with a pattern type field) - #165893 (Prune un/under used methods of `ast::Attribute`) - #166057 ([PAC] Disable rust-tail-cc for pauthtest) - #166071 (illumos dist should enable ThinLTO and codegen-units=1) - #166093 (Move doc attribute and doc comment target checking to attribute parsing) - #166098 (Actually test ABI for C ZSTs and fix Rust ZST ABI for SPARC) Failed merges: - #165267 ([Debuginfo] Emit artificial nested typedef representing generic params on MSVC)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Rollup merge of #160291 - alexhrao:i686-unknown-none, r=davidtwco Add new target: `i686-unknown-none` This adds a new tier-3 target for bare-metal 32-bit x86, which is somewhat a companion to the existing [`x86_64-unknown-none`](https://doc.rust-lang.org/rustc/platform-support/x86_64-unknown-none.html) target. Tier 3 policy: > A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.) I'll do my absolute best to support this target. > Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target. This triple name is consistent with the other 32-bit, x86 platforms > Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it. I don't think there is any ambiguity here. > Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users. I don't see any issues here. > The target must not introduce license incompatibilities. I don't think there are any new license agreements, so I don't think this is an issue. > Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0). Understood. > The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements. There are no new dependencies/features required. > Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3. It's using open source tools only. > "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users. I see no issues with any of this. > Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions. Only relevant to those making approval decisions. > This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements. Only relevant to those making approval decisions. > Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions. `core` and `alloc` can be used. `std` cannot be used as this is a bare-metal target. > The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary. Use `--target=i686-unknown-none` option to cross compile, just like any target. The target does not support running tests. > Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages. Understood. > Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications. Understood. > Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target. I believe I didn't break any other target. > In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target. I think there are no such problems in this PR. r? compiler
TDecking
pushed a commit
to TDecking/miri
that referenced
this pull request
Nov 18, 2026
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#164370 (Compact the previous dependency-node reverse index) - rust-lang/rust#164544 (Add an optional `llvm = ` argument to rustc_intrinsic.) - rust-lang/rust#165007 (std: Combine `is_mips64_feature_detected` into `is_mips_feature_detected` and enable on MIPS release 6) - rust-lang/rust#165090 (Check type alignment is <= type size in data layout parser) - rust-lang/rust#165524 (Cleanup, Get emitting metadata out of codegen) - rust-lang/rust#165875 (Combine the spans of generic arguments without dropping `->`) - rust-lang/rust#166074 (rustc: avoid path dependent queries in source presence checks) - rust-lang/rust#160291 (Add new target: `i686-unknown-none`) - rust-lang/rust#161708 (hir_typeck: Propagate async closure output into its body) - rust-lang/rust#162575 (keep the `use<..>` bound in the `refining_impl_trait` suggestion) - rust-lang/rust#163516 (Update std_detect support for AArch64 Darwin) - rust-lang/rust#163808 (Add `wasm64-unknown-emscripten` tier 3 target) - rust-lang/rust#163828 (Change all arm-none targets to skip frame pointers in leaf functions.) - rust-lang/rust#163966 (Keep deref suggestions from inserting a second pair of brackets) - rust-lang/rust#164483 (compiler: Add `{x86_64,aarch64}-unknown-serenity` targets) - rust-lang/rust#164690 (lint: keep type-changing casts in `raw_borrows_via_references`) - rust-lang/rust#164910 (Add regression tests for rust-lang/rust#164253) - rust-lang/rust#164975 (Add wide pointer visualizer for LLDB) - rust-lang/rust#165652 (Add regression test for GCA associated const with a pattern type field) - rust-lang/rust#165893 (Prune un/under used methods of `ast::Attribute`) - rust-lang/rust#166057 ([PAC] Disable rust-tail-cc for pauthtest) - rust-lang/rust#166071 (illumos dist should enable ThinLTO and codegen-units=1) - rust-lang/rust#166093 (Move doc attribute and doc comment target checking to attribute parsing) - rust-lang/rust#166098 (Actually test ABI for C ZSTs and fix Rust ZST ABI for SPARC) Failed merges: - rust-lang/rust#165267 ([Debuginfo] Emit artificial nested typedef representing generic params on MSVC)
github-actions Bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Nov 19, 2026
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#164370 (Compact the previous dependency-node reverse index) - rust-lang/rust#164544 (Add an optional `llvm = ` argument to rustc_intrinsic.) - rust-lang/rust#165007 (std: Combine `is_mips64_feature_detected` into `is_mips_feature_detected` and enable on MIPS release 6) - rust-lang/rust#165090 (Check type alignment is <= type size in data layout parser) - rust-lang/rust#165524 (Cleanup, Get emitting metadata out of codegen) - rust-lang/rust#165875 (Combine the spans of generic arguments without dropping `->`) - rust-lang/rust#166074 (rustc: avoid path dependent queries in source presence checks) - rust-lang/rust#160291 (Add new target: `i686-unknown-none`) - rust-lang/rust#161708 (hir_typeck: Propagate async closure output into its body) - rust-lang/rust#162575 (keep the `use<..>` bound in the `refining_impl_trait` suggestion) - rust-lang/rust#163516 (Update std_detect support for AArch64 Darwin) - rust-lang/rust#163808 (Add `wasm64-unknown-emscripten` tier 3 target) - rust-lang/rust#163828 (Change all arm-none targets to skip frame pointers in leaf functions.) - rust-lang/rust#163966 (Keep deref suggestions from inserting a second pair of brackets) - rust-lang/rust#164483 (compiler: Add `{x86_64,aarch64}-unknown-serenity` targets) - rust-lang/rust#164690 (lint: keep type-changing casts in `raw_borrows_via_references`) - rust-lang/rust#164910 (Add regression tests for rust-lang/rust#164253) - rust-lang/rust#164975 (Add wide pointer visualizer for LLDB) - rust-lang/rust#165652 (Add regression test for GCA associated const with a pattern type field) - rust-lang/rust#165893 (Prune un/under used methods of `ast::Attribute`) - rust-lang/rust#166057 ([PAC] Disable rust-tail-cc for pauthtest) - rust-lang/rust#166071 (illumos dist should enable ThinLTO and codegen-units=1) - rust-lang/rust#166093 (Move doc attribute and doc comment target checking to attribute parsing) - rust-lang/rust#166098 (Actually test ABI for C ZSTs and fix Rust ZST ABI for SPARC) Failed merges: - rust-lang/rust#165267 ([Debuginfo] Emit artificial nested typedef representing generic params on MSVC)
Member
|
@ojeda this should also be useful for the Linux kernel. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new tier-3 target for bare-metal 32-bit x86, which is somewhat a companion to the existing
x86_64-unknown-nonetarget.Tier 3 policy:
I'll do my absolute best to support this target.
This triple name is consistent with the other 32-bit, x86 platforms
I don't think there is any ambiguity here.
I don't see any issues here.
I don't think there are any new license agreements, so I don't think this is an issue.
Understood.
There are no new dependencies/features required.
It's using open source tools only.
I see no issues with any of this.
Only relevant to those making approval decisions.
Only relevant to those making approval decisions.
coreandalloccan be used.stdcannot be used as this is a bare-metal target.Use
--target=i686-unknown-noneoption to cross compile, just like any target. The target does not support running tests.Understood.
Understood.
I believe I didn't break any other target.
I think there are no such problems in this PR.
r? compiler