Skip to content

libsyntax: Accept use foo as bar; in lieu of use bar = foo; - #16468

Merged
bors merged 1 commit into
rust-lang:masterfrom
pcwalton:as-renaming-import
Aug 14, 2014
Merged

bors merged 1 commit into
rust-lang:masterfrom
pcwalton:as-renaming-import

Conversation

@pcwalton

Copy link
Copy Markdown
Contributor

The old syntax will be removed after a snapshot.

RFC #47.

Issue #16461.

r? @brson

Comment thread src/libsyntax/parse/parser.rs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we retain the parsing but emit a warning for awhile instead of removing this entirely after a snapshot lands? I'd just think the comment should be rephrased to say something like "make this a warning after a snapshot".

Also, could you make sure that the string "stage0" shows up here? (useful for grepping)

@alexcrichton

Copy link
Copy Markdown
Member

🌴 Thanks @pcwalton!

@alexcrichton

Copy link
Copy Markdown
Member

Ah, and one other thing, could this update the EBNF in the manual as well?

@pcwalton pcwalton changed the title libsyntax: Accept use foo as bar; in lieu of use bar as foo; libsyntax: Accept use foo as bar; in lieu of use bar = foo; Aug 14, 2014
The old syntax will be removed after a snapshot.

RFC rust-lang#47.

Issue rust-lang#16461.
bors added a commit that referenced this pull request Aug 14, 2014
The old syntax will be removed after a snapshot.

RFC #47.

Issue #16461.

r? @brson
@bors bors closed this Aug 14, 2014
@bors
bors merged commit 1c16acc into rust-lang:master Aug 14, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Feb 5, 2024
…=lnicola

minor: Recommend maintained Neovim plugin in documentation
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 12, 2026
…#16468)

Closes rust-lang/rust-clippy#16458

changelog: [`cmp_owned`] fix FP when `to_string` comes from macro input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants