Repository navigation
Remove the 'eq', 'eq_trace', and 'goals_to_obligations' methods from 'At' - #165345
Open
fallible-algebra wants to merge 1 commit into
Open
fallible-algebra wants to merge 1 commit into
fallible-algebra wants to merge 1 commit into
Conversation
Collaborator
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? lcnr |
fee1-dead
reviewed
Nov 2, 2026
Comment on lines
+239
to
+254
| if self.next_trait_solver { | ||
| return NextSolverRelate::relate( | ||
| self, | ||
| param_env, | ||
| expected, | ||
| ty::Invariant, | ||
| actual, | ||
| cause.span, | ||
| ) | ||
| .map(|goals| self.goals_to_obligations(cause, goals)); | ||
| } else { | ||
| let mut op = | ||
| TypeRelating::new(self, trace, param_env, define_opaque_types, ty::Invariant); | ||
| op.relate(expected, actual)?; | ||
| return Ok(InferOk { value: (), obligations: op.into_obligations() }); | ||
| } |
Member
There was a problem hiding this comment.
The rest of the PR overall looks fine to me, but need someone to sign off on this if next_trait_solver introduction.
fallible-algebra
force-pushed
the
at-removal/remove-eq-and-eq-trace2
branch
from
November 9, 2026 12:07
35e49c2 to
b27c369
Compare
This comment has been minimized.
This comment has been minimized.
…aw' and 'eq_trace'
fallible-algebra
force-pushed
the
at-removal/remove-eq-and-eq-trace2
branch
from
November 16, 2026 12:51
b27c369 to
0459009
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #164244, #164244 etc.