Repository navigation
Report a recursion limit error instead of delaying a bug in RPITIT collector - #165883
Merged
rust-bors[bot] merged 2 commits intoNov 20, 2026
Merged
rust-bors[bot] merged 2 commits into
rust-bors[bot] merged 2 commits into
Conversation
oli-obk
approved these changes
Nov 19, 2026
Contributor
There was a problem hiding this comment.
@bors r+ rollup
I'll add an unresolved question to the tracking issue
Contributor
4 of 8 tasks
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 19, 2026
…recursion-limit-error, r=oli-obk Report a recursion limit error instead of delaying a bug in RPITIT collector closes: rust-lang#165687 The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227. I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly. r? @oli-obk (you reviewed the original PR too 😅)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 19, 2026
…recursion-limit-error, r=oli-obk Report a recursion limit error instead of delaying a bug in RPITIT collector closes: rust-lang#165687 The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227. I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly. r? @oli-obk (you reviewed the original PR too 😅)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 19, 2026
…recursion-limit-error, r=oli-obk Report a recursion limit error instead of delaying a bug in RPITIT collector closes: rust-lang#165687 The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227. I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly. r? @oli-obk (you reviewed the original PR too 😅)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 19, 2026
…uwer Rollup of 13 pull requests Successful merges: - #157721 (compiletest: Add testing for lint machinery at runtime) - #165934 (Avoid using Terminator:None in simplify_cfg) - #166117 (Remove ebadf handling from stdio) - #165094 (reflection: doc attributes from adts, fields, and variants) - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected) - #165694 (view-types: make sure view types are !Sized) - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector) - #165971 (fix: non-deterministic temporary object paths in linker maps) - #166136 (Move ub_checks() inside the const_eval_select branch.) - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`) - #166176 (compiletest: Move all code out of the crate root) - #166185 (simd-test: Fix cfg syntax in the test macro) - #166194 (std: Unstably constify `std::process::abort`) Failed merges: - #166150 (Reflection: refactor Type and TypeKind) - #166160 (refactor CTFE-specific intrinsics to different file)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 19, 2026
…recursion-limit-error, r=oli-obk Report a recursion limit error instead of delaying a bug in RPITIT collector closes: rust-lang#165687 The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227. I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly. r? @oli-obk (you reviewed the original PR too 😅)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 19, 2026
…uwer Rollup of 16 pull requests Successful merges: - #166078 (rustc_type_ir: Optimize `sub_root_lookup_table` by using `SsoHashMap`, not `HashMap`) - #165934 (Avoid using Terminator:None in simplify_cfg) - #166050 (Use attribute parser for lang attributes in `LateResolutionVisitor`) - #166117 (Remove ebadf handling from stdio) - #166119 (Avoid an ICE on re-exports of private imports without a DefId) - #165094 (reflection: doc attributes from adts, fields, and variants) - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected) - #165694 (view-types: make sure view types are !Sized) - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector) - #165971 (fix: non-deterministic temporary object paths in linker maps) - #166064 (Add const generic transmute min support) - #166136 (Move ub_checks() inside the const_eval_select branch.) - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`) - #166176 (compiletest: Move all code out of the crate root) - #166185 (simd-test: Fix cfg syntax in the test macro) - #166194 (std: Unstably constify `std::process::abort`) Failed merges: - #166150 (Reflection: refactor Type and TypeKind) - #166160 (refactor CTFE-specific intrinsics to different file)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 20, 2026
…recursion-limit-error, r=oli-obk Report a recursion limit error instead of delaying a bug in RPITIT collector closes: rust-lang#165687 The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227. I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly. r? @oli-obk (you reviewed the original PR too 😅)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 20, 2026
Rollup of 21 pull requests Successful merges: - #165707 (bootstrap: Make low priority the default) - #165716 (Refactor split_block in check_pointers to avoid Terminator: None) - #165934 (Avoid using Terminator:None in simplify_cfg) - #166050 (Use attribute parser for lang attributes in `LateResolutionVisitor`) - #166069 (bootstrap: fix keep-stage-std) - #166117 (Remove ebadf handling from stdio) - #166119 (Avoid an ICE on re-exports of private imports without a DefId) - #165094 (reflection: doc attributes from adts, fields, and variants) - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected) - #165694 (view-types: make sure view types are !Sized) - #165802 (Add CI workflow to publish backtrace after a push to main) - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector) - #165906 (fix ICE when a forced keyword follows a parameter pattern) - #166064 (Add const generic transmute min support) - #166136 (Move ub_checks() inside the const_eval_select branch.) - #166158 (bump some tools' `toml` dependency) - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`) - #166176 (compiletest: Move all code out of the crate root) - #166185 (simd-test: Fix cfg syntax in the test macro) - #166194 (std: Unstably constify `std::process::abort`) - #166210 (Avoid terminator: None in insert_direct_enum_check) Failed merges: - #166150 (Reflection: refactor Type and TypeKind) - #166160 (refactor CTFE-specific intrinsics to different file)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 20, 2026
Rollup of 20 pull requests Successful merges: - #165716 (Refactor split_block in check_pointers to avoid Terminator: None) - #165934 (Avoid using Terminator:None in simplify_cfg) - #166050 (Use attribute parser for lang attributes in `LateResolutionVisitor`) - #166069 (bootstrap: fix keep-stage-std) - #166117 (Remove ebadf handling from stdio) - #166119 (Avoid an ICE on re-exports of private imports without a DefId) - #165094 (reflection: doc attributes from adts, fields, and variants) - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected) - #165694 (view-types: make sure view types are !Sized) - #165802 (Add CI workflow to publish backtrace after a push to main) - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector) - #165906 (fix ICE when a forced keyword follows a parameter pattern) - #166064 (Add const generic transmute min support) - #166136 (Move ub_checks() inside the const_eval_select branch.) - #166158 (bump some tools' `toml` dependency) - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`) - #166176 (compiletest: Move all code out of the crate root) - #166185 (simd-test: Fix cfg syntax in the test macro) - #166194 (std: Unstably constify `std::process::abort`) - #166210 (Avoid terminator: None in insert_direct_enum_check) Failed merges: - #166150 (Reflection: refactor Type and TypeKind) - #166160 (refactor CTFE-specific intrinsics to different file)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 20, 2026
Rollup merge of #165883 - bit-aloo:2026-11-12-rpitit-refine-recursion-limit-error, r=oli-obk Report a recursion limit error instead of delaying a bug in RPITIT collector closes: #165687 The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in #164227. I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly. r? @oli-obk (you reviewed the original PR too 😅)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #165687
The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in #164227.
I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.
r? @oli-obk (you reviewed the original PR too 😅)