Skip to content

Report a recursion limit error instead of delaying a bug in RPITIT collector - #165883

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
bit-aloo:2026-11-12-rpitit-refine-recursion-limit-error
Nov 20, 2026
Merged

rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
bit-aloo:2026-11-12-rpitit-refine-recursion-limit-error

Conversation

@bit-aloo

Copy link
Copy Markdown
Member

closes: #165687

The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in #164227.

I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.

r? @oli-obk (you reviewed the original PR too 😅)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2026

@oli-obk oli-obk left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

I'll add an unresolved question to the tracking issue

View changes since this review

@rust-bors

rust-bors Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7674cda has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 19, 2026
…recursion-limit-error, r=oli-obk

Report a recursion limit error instead of delaying a bug in RPITIT collector

closes: rust-lang#165687

The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227.

I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.

r? @oli-obk (you reviewed the original PR too 😅)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 19, 2026
…recursion-limit-error, r=oli-obk

Report a recursion limit error instead of delaying a bug in RPITIT collector

closes: rust-lang#165687

The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227.

I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.

r? @oli-obk (you reviewed the original PR too 😅)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 19, 2026
…recursion-limit-error, r=oli-obk

Report a recursion limit error instead of delaying a bug in RPITIT collector

closes: rust-lang#165687

The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227.

I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.

r? @oli-obk (you reviewed the original PR too 😅)
rust-bors Bot pushed a commit that referenced this pull request Nov 19, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157721 (compiletest: Add testing for lint machinery at runtime)
 - #165934 (Avoid using Terminator:None in simplify_cfg)
 - #166117 (Remove ebadf handling from stdio)
 - #165094 (reflection: doc attributes from adts, fields, and variants)
 - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected)
 - #165694 (view-types: make sure view types are !Sized)
 - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector)
 - #165971 (fix: non-deterministic temporary object paths in linker maps)
 - #166136 (Move ub_checks() inside the const_eval_select branch.)
 - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`)
 - #166176 (compiletest: Move all code out of the crate root)
 - #166185 (simd-test: Fix cfg syntax in the test macro)
 - #166194 (std: Unstably constify `std::process::abort`)

Failed merges:

 - #166150 (Reflection: refactor Type and TypeKind)
 - #166160 (refactor CTFE-specific intrinsics to different file)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 19, 2026
…recursion-limit-error, r=oli-obk

Report a recursion limit error instead of delaying a bug in RPITIT collector

closes: rust-lang#165687

The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227.

I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.

r? @oli-obk (you reviewed the original PR too 😅)
rust-bors Bot pushed a commit that referenced this pull request Nov 19, 2026
…uwer

Rollup of 16 pull requests

Successful merges:

 - #166078 (rustc_type_ir: Optimize `sub_root_lookup_table` by using `SsoHashMap`, not `HashMap`)
 - #165934 (Avoid using Terminator:None in simplify_cfg)
 - #166050 (Use attribute parser for lang attributes in `LateResolutionVisitor`)
 - #166117 (Remove ebadf handling from stdio)
 - #166119 (Avoid an ICE on re-exports of private imports without a DefId)
 - #165094 (reflection: doc attributes from adts, fields, and variants)
 - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected)
 - #165694 (view-types: make sure view types are !Sized)
 - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector)
 - #165971 (fix: non-deterministic temporary object paths in linker maps)
 - #166064 (Add const generic transmute min support)
 - #166136 (Move ub_checks() inside the const_eval_select branch.)
 - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`)
 - #166176 (compiletest: Move all code out of the crate root)
 - #166185 (simd-test: Fix cfg syntax in the test macro)
 - #166194 (std: Unstably constify `std::process::abort`)

Failed merges:

 - #166150 (Reflection: refactor Type and TypeKind)
 - #166160 (refactor CTFE-specific intrinsics to different file)
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 20, 2026
…recursion-limit-error, r=oli-obk

Report a recursion limit error instead of delaying a bug in RPITIT collector

closes: rust-lang#165687

The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in rust-lang#164227.

I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.

r? @oli-obk (you reviewed the original PR too 😅)
rust-bors Bot pushed a commit that referenced this pull request Nov 20, 2026
Rollup of 21 pull requests

Successful merges:

 - #165707 (bootstrap: Make low priority the default)
 - #165716 (Refactor split_block in check_pointers to avoid Terminator: None)
 - #165934 (Avoid using Terminator:None in simplify_cfg)
 - #166050 (Use attribute parser for lang attributes in `LateResolutionVisitor`)
 - #166069 (bootstrap: fix keep-stage-std)
 - #166117 (Remove ebadf handling from stdio)
 - #166119 (Avoid an ICE on re-exports of private imports without a DefId)
 - #165094 (reflection: doc attributes from adts, fields, and variants)
 - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected)
 - #165694 (view-types: make sure view types are !Sized)
 - #165802 (Add CI workflow to publish backtrace after a push to main)
 - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector)
 - #165906 (fix ICE when a forced keyword follows a parameter pattern)
 - #166064 (Add const generic transmute min support)
 - #166136 (Move ub_checks() inside the const_eval_select branch.)
 - #166158 (bump some tools' `toml` dependency)
 - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`)
 - #166176 (compiletest: Move all code out of the crate root)
 - #166185 (simd-test: Fix cfg syntax in the test macro)
 - #166194 (std: Unstably constify `std::process::abort`)
 - #166210 (Avoid terminator: None in insert_direct_enum_check)

Failed merges:

 - #166150 (Reflection: refactor Type and TypeKind)
 - #166160 (refactor CTFE-specific intrinsics to different file)
rust-bors Bot pushed a commit that referenced this pull request Nov 20, 2026
Rollup of 20 pull requests

Successful merges:

 - #165716 (Refactor split_block in check_pointers to avoid Terminator: None)
 - #165934 (Avoid using Terminator:None in simplify_cfg)
 - #166050 (Use attribute parser for lang attributes in `LateResolutionVisitor`)
 - #166069 (bootstrap: fix keep-stage-std)
 - #166117 (Remove ebadf handling from stdio)
 - #166119 (Avoid an ICE on re-exports of private imports without a DefId)
 - #165094 (reflection: doc attributes from adts, fields, and variants)
 - #165216 (Clearer diagnostics when `&FnOnce` was provided when `FnOnce` was expected)
 - #165694 (view-types: make sure view types are !Sized)
 - #165802 (Add CI workflow to publish backtrace after a push to main)
 - #165883 (Report a recursion limit error instead of delaying a bug in RPITIT collector)
 - #165906 (fix ICE when a forced keyword follows a parameter pattern)
 - #166064 (Add const generic transmute min support)
 - #166136 (Move ub_checks() inside the const_eval_select branch.)
 - #166158 (bump some tools' `toml` dependency)
 - #166166 (Don't recover if not allowed in `parse_seq_to_before_tokens`)
 - #166176 (compiletest: Move all code out of the crate root)
 - #166185 (simd-test: Fix cfg syntax in the test macro)
 - #166194 (std: Unstably constify `std::process::abort`)
 - #166210 (Avoid terminator: None in insert_direct_enum_check)

Failed merges:

 - #166150 (Reflection: refactor Type and TypeKind)
 - #166160 (refactor CTFE-specific intrinsics to different file)
@rust-bors
rust-bors Bot merged commit 8dedb31 into rust-lang:main Nov 20, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 20, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 20, 2026
Rollup merge of #165883 - bit-aloo:2026-11-12-rpitit-refine-recursion-limit-error, r=oli-obk

Report a recursion limit error instead of delaying a bug in RPITIT collector

closes: #165687

The ICE happens because we delay a recursion error, but no other error is emitted. Deduplicating by defId would prevent the recursion, but could reject valid cases involving coinductive cycles (though I couldn't come up with an example). For now, emitting a hard error at the recursion limit prevents the ICE, the changes were introduced in #164227.

I think a proper fix would involve finding a way to allow the example in the issue while also making sure we handle cycles correctly.

r? @oli-obk (you reviewed the original PR too 😅)
@bit-aloo
bit-aloo deleted the 2026-11-12-rpitit-refine-recursion-limit-error branch November 20, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: recursion limit exceeded while collecting implied RPITIT bounds

3 participants