Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
beetrees
force-pushed
the
fix-trivial-abi-layout
branch
from
November 20, 2026 03:18
329f4c1 to
90d6dd8
Compare
Member
So this is basically fixing a bug in #156112. @Jules-Bertholet does this look reasonable? @beetrees could you add a test for the case that was buggy? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ABI layout handling of trivial ABI currently only checks that the type is a 1-ZST and doesn't contain any
repr(C)types: however the documentation for trivial ABIs states that any array with a non-trivial element type is itself non-trivial. This means that the current ABI code considers types like[u8; 0]to be trivial even though they are not - this PR fixes it to match the documentation. This isn't particularly important for arguments/returns as C doesn't allow plain arrays in the argument/return positions, but it is important in other places. Found by @chenx97 in #164628. Split out from #166170.r? @bjorn3