Repository navigation
Warn that the link target ignores the given name - #38840
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
nrc
left a comment
There was a problem hiding this comment.
Looks like the correct change, I think the error message could be improved a little. Thanks for the PR!
| requested"); | ||
| let ofile = if unnamed_output_types > 1 && | ||
| sess.opts.output_types.contains_key(&OutputType::Exe) { | ||
| sess.warn("ignoring output name requested with -o for \"link\" output because \ |
There was a problem hiding this comment.
I think you could change the error message less - in particular, keeping filename rather than name seems more informative, and I don't think mentioning -o is necessary. Nit: I would prefer using single quotes or backticks rather than double quotes around link.
There was a problem hiding this comment.
Sure. I just copied the message suggested in the issue comments.
|
@bors: r+ |
|
📌 Commit 4af830a has been approved by |
Warn that the link target ignores the given name Hi, new contributor here. This is my stab at #20130, any feedback welcome!
|
☀️ Test successful - status-appveyor, status-travis |
Hi, new contributor here. This is my stab at #20130, any feedback welcome!