Skip to content

Warn that the link target ignores the given name - #38840

Merged
bors merged 2 commits into
rust-lang:masterfrom
kjaleshire:multiple-targets-error-fix
Jan 9, 2017
Merged

bors merged 2 commits into
rust-lang:masterfrom
kjaleshire:multiple-targets-error-fix

Conversation

@kjaleshire

Copy link
Copy Markdown
Contributor

Hi, new contributor here. This is my stab at #20130, any feedback welcome!

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nrc nrc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the correct change, I think the error message could be improved a little. Thanks for the PR!

Comment thread src/librustc_driver/driver.rs Outdated
requested");
let ofile = if unnamed_output_types > 1 &&
sess.opts.output_types.contains_key(&OutputType::Exe) {
sess.warn("ignoring output name requested with -o for \"link\" output because \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could change the error message less - in particular, keeping filename rather than name seems more informative, and I don't think mentioning -o is necessary. Nit: I would prefer using single quotes or backticks rather than double quotes around link.

@kjaleshire kjaleshire Jan 7, 2017 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I just copied the message suggested in the issue comments.

@nrc

nrc commented Jan 9, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

📌 Commit 4af830a has been approved by nrc

@bors

bors commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit 4af830a with merge f5cfe83...

bors added a commit that referenced this pull request Jan 9, 2017
Warn that the link target ignores the given name

Hi, new contributor here. This is my stab at #20130, any feedback welcome!
@bors

bors commented Jan 9, 2017

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing f5cfe83 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants