Repository navigation
Try fix incorrect "explicit lifetime name needed" - #65307
Conversation
commented
Oct 11, 2019
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
commented
Oct 11, 2019
|
r? @varkor maybe? |
commented
Oct 11, 2019
|
Can you add a test with the new diagnostic? |
commented
Oct 11, 2019
|
Sure yes, there ought to be a test correspond to this issue. |
|
It seems enough to solve this issue, please review 😃 |
There was a problem hiding this comment.
This could be if id.is_some() { … }.
There was a problem hiding this comment.
This is always called with None, so you might as well just use new_implicit_lifetime here, no?
There was a problem hiding this comment.
Well, shame of me. Thanks for pointing out XD
There was a problem hiding this comment.
It's not clear to me from this comment why this change works. Could you try to elaborate what this does in your comment?
commented
Oct 14, 2019
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
commented
Oct 14, 2019
|
r=me with comment suggestion and squashing the commits. |
commented
Oct 14, 2019
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
commented
Oct 14, 2019
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
commented
Oct 15, 2019
There were something wrong with CI, and I just tried to trigger the re-run by a commit, I'll revert this change |
commented
Oct 15, 2019
|
In the future, you can trigger the CI to restart by amending the last commit and force-pushing. If you could squash your commits into a single commit, I'll approve the PR :) |
add test to for the fix add descriptive text for the fix simplified code logics update descriptive comments update to cope with the tidyness requirement merged commit suggestions Co-Authored-By: varkor <github@varkor.com> truncated redundant comments update to cope with tidy-check
commented
Oct 15, 2019
|
Thanks a lot 🎁 , I'm somewhat new to the rust community and you've helped me greatly. |
commented
Oct 15, 2019
|
Thanks for your work on this issue! @bors r+ rollup |
commented
Oct 15, 2019
|
📌 Commit 53187c5 has been approved by |
This pr is trying to fixes #65285 .