Repository navigation
Bump remove_dir_all - #3244
Merged
Merged
Bump remove_dir_all#3244
Conversation
Member
Sorry, I am not sure I get the point. Do you mean rustup will delete some files that users do not expect to delete? How will the |
Contributor
Author
|
Current master uses a version of remove_dir_all that has parallel enabled by default. This PR just keeps the current feature. The parallel deletion feature helps with the performance of removing toolchains - which have 10's of thousands of files. The reason for the upgrade is a new release - as usual - but also there is a CVE in older versions that means we should upgrade now rather than later. |
0xPoe
approved these changes
Feb 28, 2023
Member
There was a problem hiding this comment.
I found the description in the changelog for this CVE. Thanks!
While this fixes a TOCTOU bug in the dependency, rustup is run either as an unprivileged process, or as a privileged process operating on a file tree that the privileged user owns; it is not a setuid binary and that mitigates much of the vulnerability: a deliberately misconfigured sudoers or similar would be required. Thus this hardens rustup against misconfiguration, but does not close an active vulnerability in how rustup is designed to be used.
rbtcollins
force-pushed
the
remove-dir-all
branch
from
February 28, 2023 06:59
29bf6ac to
3c4784c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this fixes a TOCTOU bug in the dependency, rustup is run either as an unprivileged process, or as a privileged process operating on a file tree that the privileged user owns; it is not a setuid binary and that mitigates much of the vulnerability: a deliberately misconfigured sudoers or similar would be required. Thus this hardens rustup against misconfiguration, but does not close an active vulnerability in how rustup is designed to be used.