Skip to content

crates-io: Disable versioning for rss/ contents - #439

Merged
marcoieni merged 2 commits into
rust-lang:masterfrom
Turbo87:disable-feeds-versioning
Aug 5, 2024
Merged

marcoieni merged 2 commits into
rust-lang:masterfrom
Turbo87:disable-feeds-versioning

Conversation

@Turbo87

@Turbo87 Turbo87 commented Jul 6, 2024

Copy link
Copy Markdown
Member

Note that I have absolutely no idea if the content of this PR works or not since there does not seem to be a way for me to check this, but the intention is to disable S3 versioning for all files inside the rss/ folder on S3.

r? @rust-lang/infra

@emilyalbini

Copy link
Copy Markdown
Member

You cannot disable versioning for just a subset of objects in a bucket, versioning is a global setting that applies to the whole bucket. Pushed a commit with a working version of this configuration, which deletes non-current versions of the feed after one day.

I'll let someone else in t-infra apply this (I don't have fastly keys on the machine I'm currently using).

@Turbo87

Turbo87 commented Jul 12, 2024

Copy link
Copy Markdown
Member Author

r? @rust-lang/infra ?

@jdno jdno self-assigned this Jul 17, 2024
@jdno

jdno commented Jul 17, 2024

Copy link
Copy Markdown
Member

The changes here are live on staging.

@marcoieni

Copy link
Copy Markdown
Member

The changes here are live on staging.

Should we merge this and apply to prod as well?

Right now terragrunt plan is not clean on master because it detects this change.

@jdno

jdno commented Aug 5, 2024

Copy link
Copy Markdown
Member

I just checked the staging bucket and each file in /rss only has the most recent version. So this seems to work and I think we can deploy it to prod as well, yes.

@marcoieni
marcoieni merged commit f6b400a into rust-lang:master Aug 5, 2024
@marcoieni

Copy link
Copy Markdown
Member

I'm deploying to prod, then 🎉

@marcoieni marcoieni mentioned this pull request Aug 5, 2024
@marcoieni

Copy link
Copy Markdown
Member

Done 👍

@Turbo87
Turbo87 deleted the disable-feeds-versioning branch July 15, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants