Repository navigation
Validate crates.io config of archived repos - #2969
Open
marcoienibot wants to merge 1 commit into
Open
marcoienibot wants to merge 1 commit into
marcoienibot wants to merge 1 commit into
Conversation
validate_trusted_publishing only iterated active repos, so [[crates-io]] sections in archived repos were never validated. An empty crate list, or the same crate listed in an archived and an active repo, passed validation, and the crates.io sync silently kept only one of the duplicate entries.
Dry-run check results |
marcoieni
marked this pull request as ready for review
November 19, 2026 16:17
marcoieni
requested review from
Mark-Simulacrum,
emilyalbini,
jdno,
jieyouxu,
marcoieni and
ubiratansoares
as code owners
November 19, 2026 16:17
ubiratansoares
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_trusted_publishingiterateddata.repos(), which skips archived repos, so[[crates-io]]sections underrepos/archive/were never validated.The crates.io sync reads crates from
repos.json, which includes archived repos, and collects them into a map keyed by crate name. So a crate listed in both an archived repo and an active repo passed validation, and the sync silently kept only one of the two configurations. An empty crate list, an undefined environment, or an unknown owner team in an archived repo also went unnoticed.This switches the check to
data.all_repos(), like the other repo validators in the same file.