Skip to content

Validate crates.io config of archived repos - #2969

Open
marcoienibot wants to merge 1 commit into
rust-lang:mainfrom
marcoienibot:t3/validate-archived-crates
Open

marcoienibot wants to merge 1 commit into
rust-lang:mainfrom
marcoienibot:t3/validate-archived-crates

Conversation

@marcoienibot

@marcoienibot marcoienibot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

validate_trusted_publishing iterated data.repos(), which skips archived repos, so [[crates-io]] sections under repos/archive/ were never validated.

The crates.io sync reads crates from repos.json, which includes archived repos, and collects them into a map keyed by crate name. So a crate listed in both an archived repo and an active repo passed validation, and the sync silently kept only one of the two configurations. An empty crate list, an undefined environment, or an unknown owner team in an archived repo also went unnoticed.

This switches the check to data.all_repos(), like the other repo validators in the same file.

validate_trusted_publishing only iterated active repos, so [[crates-io]]
sections in archived repos were never validated. An empty crate list, or
the same crate listed in an archived and an active repo, passed
validation, and the crates.io sync silently kept only one of the
duplicate entries.
@github-actions

Copy link
Copy Markdown
Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github
[INFO  rust_team::sync] Rate limits before: REST 14525/15000 remaining, resets at 2026-11-19 15:23:24 UTC, GraphQL 12410/12500 remaining, resets at 2026-11-19 15:23:06 UTC
[INFO  rust_team::sync] Rate limits after: REST 14050/15000 remaining, resets at 2026-11-19 15:23:24 UTC, GraphQL 12325/12500 remaining, resets at 2026-11-19 15:23:06 UTC
[INFO  rust_team::sync] Consumed 475 REST calls and 85 GraphQL calls

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants