Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A complete header buffered by
create_readerwas followed by a second read infrom_buffer, which can fail when a streaming decoder receives an empty output buffer or block waiting for more input. Reuse the buffered header for both PCAP and PCAPNG readers.Fixes #57.
Validation: the original full-buffer/header regressions fail; all 64 unit/integration tests with all features and all 50 without default features pass.
cargo check --all-features, formatting and diff checks pass. The added readers are fixtures modeling a decoder rejecting empty output and a producer that must not be read again; no zstd process is used.On current stable, the full test command still fails two existing doctests with denied unused-assignment warnings, and strict Clippy has 11 existing warnings/errors. Both reproduce on unchanged master a5ca3c6; neither is described as passing.