Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big-endian interface timestamp offsets decode incorrectly: an offset of 1 becomes 72057594037927936. Decode the cached offset and option getter in the block byte order, and convert existing offset options when checked serialization produces its documented little-endian output.
Fixes #62.
Validation: both original endian/serialization regressions fail; all 62 unit/integration tests with all features and all 47 without default features pass. The fixtures cover positive/negative/boundary offsets, both byte orders, BE-to-LE serialization and repeated serialization.
cargo check --all-features, formatting and diff checks pass.Current stable still rejects two unchanged doctests for denied unused-assignment warnings. Strict Clippy has the same 11 existing errors as clean master a5ca3c6. These baseline failures remain; no full-suite/strict-lint pass is claimed.