Skip to content

Respect section endianness for interface timestamp offsets - #64

Open
omrzk wants to merge 1 commit into
rusticata:masterfrom
omrzk:fix/pcapng-offset-endianness-62
Open

omrzk wants to merge 1 commit into
rusticata:masterfrom
omrzk:fix/pcapng-offset-endianness-62

Conversation

@omrzk

@omrzk omrzk commented Oct 31, 2026

Copy link
Copy Markdown

Big-endian interface timestamp offsets decode incorrectly: an offset of 1 becomes 72057594037927936. Decode the cached offset and option getter in the block byte order, and convert existing offset options when checked serialization produces its documented little-endian output.

Fixes #62.

Validation: both original endian/serialization regressions fail; all 62 unit/integration tests with all features and all 47 without default features pass. The fixtures cover positive/negative/boundary offsets, both byte orders, BE-to-LE serialization and repeated serialization. cargo check --all-features, formatting and diff checks pass.

Current stable still rejects two unchanged doctests for denied unused-assignment warnings. Strict Clippy has the same 11 existing errors as clean master a5ca3c6. These baseline failures remain; no full-suite/strict-lint pass is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

if_tsoffset is always parsed as little-endian

1 participant