Repository navigation
Conversation
pod-tick.test.mjs's own header says "uses Node's built-in test runner
(no extra deps). Run with: node --test" and it imports test() from
node:test, not vitest — exactly the category scripts/ci-test-excluded.txt
exists for ("the .mjs files use node:test: node --test runs them"). It
was miscategorized into ci-test-baseline.txt instead (vitest CAN run it,
it just currently fails), so the root vitest ratchet has been executing
a node:test file on every PR.
This explains a ~4-in-6 repro rate on PR #4306 of the root Test Suite job
crashing with tinypool's ERR_IPC_CHANNEL_CLOSED ("Channel closed"),
consistently right after this file's last test completes — six spawnSync
child-process calls inside a vitest-hosted node:test file is exactly the
kind of worker-lifecycle interaction likely to corrupt the shared process.
Tracked in #4307 with the full crash evidence.
Verified: 21/21 passing under its real runner
(`node --test plugins/ruflo-business-pods/scripts/pod-tick.test.mjs`).
Co-Authored-By: RuFlo <ruv@ruv.net>
ruvnet
added a commit
that referenced
this pull request
Oct 20, 2026
Same fix as #4308: this file imports test() from node:test (not vitest) and documents itself as "Run with: node --test" in its own header, but was miscategorized into ci-test-baseline.txt. Running it under vitest's shared worker process correlates strongly with the ERR_IPC_CHANNEL_CLOSED crash hit 4/6 times on this PR's own CI (#4307). Applying here directly so this release doesn't wait on #4308 to merge first. Co-Authored-By: RuFlo <ruv@ruv.net>
ruvnet
added a commit
that referenced
this pull request
Oct 20, 2026
* chore(release): 3.58.0 version bumps and changelog Minor release: new memory peek command, Codex activity viewer, configurable MCP rate limits, plus the #4303 install-breaking fix and a round of correctness fixes merged since 3.57.2. Also bumps ruflo-console 0.44.4 -> 0.44.5 for the #4305 TUI fix, which shipped to main without a plugin version bump (the same gap already documented as a past mistake in the console's own changelog for 0.44.3/0.44.4). Co-Authored-By: RuFlo <ruv@ruv.net> * fix(ruflo-console): update smoke.sh's hardcoded version check to 0.44.5 The plugin.json version bump to 0.44.5 (for the #4305 TUI fix) broke the smoke contract's own hardcoded expectation of 0.44.4 in step 1. Update the step name and grep pattern to match. Co-Authored-By: RuFlo <ruv@ruv.net> * fix(ci): sync the smoke-workflow regression test to the real 15-minute timeout #3950 bumped .github/workflows/all-plugins-smoke.yml's smoke-all job from timeout-minutes 10 to 15 (the job now also checks out and smokes the first external git-subdir marketplace entry, agentic-qe-fleet) but never updated this test's hardcoded expectation of 10, breaking the Test Suite job on every PR since. Co-Authored-By: RuFlo <ruv@ruv.net> * fix(memory): resolve sql.js's wasm dist path directly, not via package.json fts5.test.ts located sql-wasm.wasm via require.resolve('sql.js/package.json') then string-replaced the suffix. sql.js 1.14 tightened its exports map to "." and "./dist/*" only, so that package.json subpath resolve throws ERR_PACKAGE_PATH_NOT_EXPORTED even though the wasm file is present on disk — caught by the existing try/catch and misreported as "sql.js isn't installed", failing all 4 SqlJsBackend FTS5 tests with "sql.js/dist/sql-wasm.wasm not found". Resolve 'sql.js/dist/sql-wasm.wasm' directly instead, which the "./dist/*" export already permits. Verified: 6/6 passing locally (was 4 failed before the fix). Co-Authored-By: RuFlo <ruv@ruv.net> * fix(ci): move pod-tick.test.mjs to the node:test exclusion list Same fix as #4308: this file imports test() from node:test (not vitest) and documents itself as "Run with: node --test" in its own header, but was miscategorized into ci-test-baseline.txt. Running it under vitest's shared worker process correlates strongly with the ERR_IPC_CHANNEL_CLOSED crash hit 4/6 times on this PR's own CI (#4307). Applying here directly so this release doesn't wait on #4308 to merge first. Co-Authored-By: RuFlo <ruv@ruv.net> * fix(ci): cap the ratchet's vitest worker count to 2 #4307: Test Suite (ubuntu-latest) intermittently crashes with tinypool's ERR_IPC_CHANNEL_CLOSED at three different, unrelated points across 7 runs on this PR, after ruling out any specific file as the cause (one candidate, pod-tick.test.mjs, was fixed separately for an unrelated reason and the crash still recurred at a different file). The pattern (crash location varies, happens ~60-90s into a ~9500-test run) is more consistent with cumulative memory pressure across the default fork pool (one fork per CPU, ~4 on a standard runner) than a single bad test. Capping workers at 2 trades some wall-clock time for headroom while the real cause is still open in #4307. Co-Authored-By: RuFlo <ruv@ruv.net> * fix(graph-intelligence): build the optional cli import specifier from parts #4307 investigation, round 8: once the worker-cap fix (3739f3a) stopped the random tinypool crash, Test Suite started failing deterministically on plugins/ruflo-graph-intelligence/tests/phase4-adapters.spec.ts — "./src/memory/graph-edge-writer.js" is not exported, even though that spec file's own tests never execute the real GraphEdgesSource.listEdges() (they all use inline fake listEdges() test doubles). The spec file does statically import knowledge-graph-adapter.ts at module level, though, so vitest's module-graph crawl sees the string literal and (CI-only, not reproduced locally in 2/2 attempts) appears to eagerly resolve it outside this method's own try/catch during collection. Build both the primary and fallback specifiers from joined array parts instead of literals, so no bundler's static import-specifier scan can find and pre-resolve them — the actual resolution still only happens at the real `await import(...)` call site, same as before. Verified: full plugin suite green, 104/104 (was 8/8 on the one affected file already — this closes the only CI-only gap). Co-Authored-By: RuFlo <ruv@ruv.net> * fix(ci): baseline token-optimizer.test.ts — real, pre-existing, unrelated bug v3/@claude-flow/integration/src/token-optimizer.ts calls this.agentBooster.editCode(...), but the real agentic-flow/agent-booster module's AgentBooster/EnhancedAgentBooster class has no editCode method at all (its real API is apply/applyBatch/prefetch/...). Confirmed by enumerating the class prototype directly. Not a version-pin issue, not caused by anything in this release — @claude-flow/integration isn't even part of the release train. Filed as #4311 with the real-fix suggestion (rewrite optimizedEdit() against the actual API) for whoever owns that integration layer; baselining here so the Test Suite ratchet reflects reality instead of blocking an unrelated release on pre-existing debt. Co-Authored-By: RuFlo <ruv@ruv.net> * docs(changelog): record the CI-reliability fixes found validating 3.58.0 Co-Authored-By: RuFlo <ruv@ruv.net> --------- Co-authored-by: r <r@x>
Owner
Author
|
Superseded — this exact change landed on main via #4306 (the 3.58.0 release, which needed it to get a clean Test Suite run). Closing rather than merging an empty diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/ruflo-business-pods/scripts/pod-tick.test.mjsis anode:testfile (its own header: "uses Node's built-in test runner (no extra deps). Run with: node --test") that was listed inscripts/ci-test-baseline.txt(vitest-can-run-it-but-currently-fails) instead ofscripts/ci-test-excluded.txt(vitest-cannot-run-it-at-all, usesnode:test) — a miscategorization, since the excluded list exists for exactly this case and a sibling file (tdd-repair.test.mjs) with the identical pattern is already there.Running a
node:test-based file inside vitest's shared worker process, especially one with sixspawnSyncchild-process calls, correlates strongly with a rootTest Suite (ubuntu-latest)CI job crash:tinypool'sERR_IPC_CHANNEL_CLOSED("Channel closed"), reproduced 4 times out of 6 consecutive runs on #4306, every time landing right after this file's last test completes.Filed with full evidence as #4307. This fix (move the one line to the correct list) doesn't prove the causal mechanism with certainty, but it's independently correct per the project's own documented categorization rules regardless of whether it resolves the crash, and is worth landing on its own, fast, since the crash affects every PR's CI right now.
Test plan
node --test plugins/ruflo-business-pods/scripts/pod-tick.test.mjs— 21/21 passing under its real, intended runnerci-test-excluded.txt(plugins/ruflo-testgen/scripts/tdd-repair/tdd-repair.test.mjs)Related: #4307
🤖 Generated with RuFlo