Skip to content

golive journal: 'failed before its first step changed nothing' is not enforced for later commands #186

Closed

Description

@scuttletoby

From the #182 quick check (#182 (comment)), minor 1, fork-kit/golive/.../journal.py:154. A later command (e.g. switch arming its rollback timer outside a step) that fails would leave check answering ok. Also the switch pre-check runs inside a step in the PR's own test, so every refused pre-check needs a settle. Fix: write the rule down and enforce it (changes only inside journalled steps), keep pre-checks outside steps. A failing probe test exists (lens scratch, kept by the orchestrator).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions