You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
golive journal: 'failed before its first step changed nothing' is not enforced for later commands #186
From the #182 quick check (#182 (comment)), minor 1, fork-kit/golive/.../journal.py:154. A later command (e.g. switch arming its rollback timer outside a step) that fails would leave check answering ok. Also the switch pre-check runs inside a step in the PR's own test, so every refused pre-check needs a settle. Fix: write the rule down and enforce it (changes only inside journalled steps), keep pre-checks outside steps. A failing probe test exists (lens scratch, kept by the orchestrator).
Activity