Skip to content

desk link: flaky timing test, untested lock-owner check, socket peer check #202

Open

Description

@scuttletoby

Follow-ups from the re-check of #192 (desk link, always-on side), comment #192 (comment). None blocks; fix before the desk link runs real jobs.

  • Flaky run: the desk tests failed once in 27 runs; the failing test was not captured. Some timing tests have small margins. Widen the margins and find the one that failed (known-failing tests are fixed first, never re-run away).
  • Untested guard: the check on the dispatcher lock file's owner has no test that fails without it.
  • Socket swap race: root connects to the socket inside a folder the desk user owns. Add a peer-credential check after connecting (SO_PEERCRED: the peer must be the desk user).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions