Repository navigation
semgrep hook prints header many times #30
Description
pre-commit runs multiple processes in parallel with a group of files, and since semgrep always outputs a header/title even with --quiet, you get this:
❯ pre-commit run --all-files semgrep
semgrep..................................................................Failed
- hook id: semgrep
- exit code: 1
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌────────────────┐
│ 1 Code Finding │
└────────────────┘
src/redacted/redacted.py
❯❯❱ redacted
Some rule description goes here
305┆ redacted()
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘
If semgrep does its own multithreading/processing then the hook could use require_serial: true, but I'd still argue the header shouldn't be printed with --quiet.
Reacted by goodspark, Danny Staple, Patrick, Jakub Sokołowski and Christophe Simonis
Activity