Skip to content

TSA verification - #44

Merged
segiddins merged 1 commit into
mainfrom
segiddins/tsa-verification
Jun 28, 2024
Merged

segiddins merged 1 commit into
mainfrom
segiddins/tsa-verification

Conversation

@segiddins

Copy link
Copy Markdown
Member

Depends on ruby/openssl#770

@segiddins
segiddins force-pushed the segiddins/tsa-verification branch from f66f38f to a7ce3ab Compare June 27, 2024 18:42
@segiddins
segiddins marked this pull request as ready for review June 27, 2024 18:42
Comment thread lib/sigstore/verifier.rb
rescue OpenSSL::Timestamp::TimestampError => _e
# raise OpenSSL::Timestamp::TimestampError, "#{e} for #{chain.map(&:to_text).join("\n")}\n#{debug}"
true
resp.verify(req, store, chain) &&

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me! At least, from what I know of OpenSSL's TSR/TSA APIs.

@segiddins
segiddins enabled auto-merge (squash) June 27, 2024 20:34
@segiddins

Copy link
Copy Markdown
Member Author
GitHub Advanced Security / CodeQL
succeeded 3 hours ago in 3s

yet

Merging is blocked
Code scanning has not received results from CodeQL.

Depends on ruby/openssl#770

Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
@segiddins
segiddins force-pushed the segiddins/tsa-verification branch from a7ce3ab to f440cea Compare June 28, 2024 16:32
@segiddins
segiddins merged commit aa730d4 into main Jun 28, 2024
@segiddins
segiddins deleted the segiddins/tsa-verification branch June 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants