Skip to content

Rename Moped::BSON::ObjectID to BSON::ObjectId and Add restore callbacks. - #8

Closed
zhouguangming wants to merge 2 commits into
simi:masterfrom
zhouguangming:master
Closed

zhouguangming wants to merge 2 commits into
simi:masterfrom
zhouguangming:master

Conversation

@zhouguangming

Copy link
Copy Markdown

Moped beta 2 uses the 10gen bson gem (2.0.0.rc2), so just use BSON:ObjectId now.
https://github.com/mongoid/mongoid/issues/3294

Can you review this PR? @simi

@simi

simi commented Oct 14, 2013

Copy link
Copy Markdown
Owner

@zhouguangming I just added same commits :) LOL

@simi

simi commented Oct 14, 2013

Copy link
Copy Markdown
Owner

Check 3f36057 and #7.

@simi

simi commented Oct 14, 2013

Copy link
Copy Markdown
Owner

I merged my PR since I committed it sooner. Our codes are basically same. Thanks for idea.

What a crazy coincidence we made same commits within 2 minutes. ⌚ Time to improve README.

@simi simi closed this Oct 14, 2013
@zhouguangming

Copy link
Copy Markdown
Author

Yes, I was shocked. 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants