Repository navigation
fix(gestures): reject out-of-range normalized coordinates - #1530
Open
monsterlag wants to merge 1 commit into
Open
monsterlag wants to merge 1 commit into
monsterlag wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-generated, not reviewed by a human. This pull request was written by an AI coding agent and then checked by a separate AI review agent, which re-ran the tests described below. No human has reviewed the code. It is submitted by @monsterlag, who runs these agents. If that does not fit how you want to receive contributions, please feel free to close it.
Summary
Fixes #1472.
gesture-tap,gesture-swipe,gesture-scroll, andgesture-dragdocumented normalized positions but accepted negative or pixel-valued coordinates. Calls could report success without performing the intended interaction.Add inclusive 0–1 bounds to their position fields in the Zod schemas. Existing validation now rejects invalid coordinates by name before service resolution, including nested
run-sequenceand e2e calls. The advertised JSON schemas carry the same limits. Scroll deltas and backend dispatch behavior are unchanged.Add table-driven regressions for every position field, valid boundaries, advertised limits, registry validation, sequence stopping, and unrestricted signed scroll deltas. Update the tools reference with the rejection behavior.
Testing
npm test -w @argent/tool-server -- --maxWorkers=2).npm run buildnpm run typecheck:tests --workspaces --if-presentnpm run typecheck:scriptsandnpm run test:scripts(93 passed)npx docusaurus buildContainer notes: the full suite ran under a temporary orphan-process reaper because PID 1 does not reap zombies here. ESLint checked all files in memory-bounded batches, then passed the root command using that cache. No project configuration changed. No live-device testing was performed.