Repository navigation
Conversation
Statement#to_a came from Enumerable, so each row went through #each, which used Kernel#loop and called #step and #done? from Ruby. Rails' SQLite3 adapter calls Statement#to_a for every query.
Database#execute without a block calls ResultSet#to_a, which went through Enumerable and #next. It now calls Statement#to_a. For results_as_hash, each row was built with columns.zip(row).to_h, which allocated the zipped Array and an Array for each column pair before the Hash. HashResultSet#to_a now builds each Hash from the row in C. This keeps the zip behaviour: duplicate column names take the last value.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously to_a was
Enumerable#to_awhich requires a call to step and done for each row. It's faster to just accumulate the full result.Before:
After: