Skip to content

[CMake 4/7] Make probability test fixtures safe for grouped linking - #3504

Merged
WardBrian merged 1 commit into
developfrom
cmake-split/04-probability-tests
Nov 13, 2026
Merged

WardBrian merged 1 commit into
developfrom
cmake-split/04-probability-tests

Conversation

@SteveBronder

@SteveBronder SteveBronder commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Generated probability sources include fixture headers in multiple translation units. Inline header-defined helpers, distinguish four colliding fixture class names, and move ordinary GoogleTests from fixture headers into their unit-test sources. All 12 moved test blocks retain their original contents.

Part 4 of the CMake migration split from #3463.

Targets cmake-split/03-tbb-isolation (#3503) as the preceding layer of the native stack. The review contains only this layer's prepared patch and its supporting tests.

Tests

  • Reproduced all four fixture-name collisions; renamed fixtures compile together.
  • Verified all 12 relocated test blocks against their original contents.
  • Independent Make Bernoulli CDF test passes.
  • The combined CMake stack passes 324 generated Bernoulli tests.
  • The complete probability matrix remains for CI.

Side Effects

Test fixture names change to avoid collisions, and ordinary tests run once in their unit sources instead of being repeated in generated probability sources.

Release notes

Prepare generated probability fixtures for grouped linking without duplicating ordinary tests.

Checklist

  • Copyright holder: Simons Foundation
  • The complete basic-test and CI matrix is passing
  • C++ idioms and Doxygen documentation have completed review
  • Focused validation is passing as described above; remaining coverage is listed

Related PRs

Native stack: https://github.com/stan-dev/math/stack/3509

WardBrian
WardBrian previously approved these changes Nov 3, 2026
@SteveBronder
SteveBronder enabled stacked auto-merge November 4, 2026 16:15
stacked auto-merge was automatically disabled November 4, 2026 16:44

Auto-merge was disabled for another pull request in the stack

@SteveBronder
SteveBronder removed this pull request from stack #3507 November 4, 2026 16:44
@SteveBronder
SteveBronder added this pull request to stack #3509 November 4, 2026 16:44
@SteveBronder SteveBronder changed the title [CMake 4/6] Make probability test fixtures safe for grouped linking [CMake 4/7] Make probability test fixtures safe for grouped linking Nov 4, 2026
@SteveBronder
SteveBronder force-pushed the cmake-split/04-probability-tests branch from 320f21c to 9bac38c Compare November 5, 2026 14:39
@WardBrian
WardBrian force-pushed the cmake-split/04-probability-tests branch from 9bac38c to f9899e0 Compare November 6, 2026 10:47
Base automatically changed from cmake-split/03-tbb-isolation to develop November 6, 2026 20:06
Inline shared probability-test helpers and distinguish colliding fixture
types. Move ordinary GoogleTests out of generated fixture headers into
unit sources, preserving their assertions and avoiding duplicate tests.
@WardBrian
WardBrian force-pushed the cmake-split/04-probability-tests branch from f9899e0 to 8c2c013 Compare November 6, 2026 20:06
@stan-buildbot

Copy link
Copy Markdown
Contributor
Name Old Result New Result Ratio Performance change( 1 - new / old )
stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan 0.04 0.04 0.97 -2.93% slower
stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan 0.18 0.18 0.98 -1.61% slower
stat_comp_benchmarks/benchmarks/garch/garch.stan 0.96 0.96 1.01 0.72% faster
stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -1.16% slower
stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan 0.11 0.11 1.0 0.34% faster
stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan 8.04 8.05 1.0 -0.15% slower
stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan 3.98 4.03 0.99 -1.38% slower
stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan 32.82 32.56 1.01 0.8% faster
stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan 0.39 0.39 1.01 0.65% faster
stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan 7.93 7.92 1.0 0.12% faster
stat_comp_benchmarks/benchmarks/sir/sir.stan 166.62 165.77 1.01 0.51% faster
stat_comp_benchmarks/benchmarks/arK/arK.stan 3.44 3.43 1.0 0.32% faster
stat_comp_benchmarks/benchmarks/arma/arma.stan 0.58 0.58 1.01 1.44% faster
stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 25.29 25.32 1.0 -0.14% slower
performance.compilation 386.82 395.98 0.98 -2.37% slower
Mean result: 0.9969322814420963

Jenkins Console Log
Jenkins Build Stages
Commit hash: 391d3a4b1515dc036b8b287d10029ea398102ec2

Machine information
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.3 LTS
Release:	20.04
Codename:	focal

CPU:

Architecture:                            x86_64
CPU op-mode(s):                          32-bit, 64-bit
Byte Order:                              Little Endian
Address sizes:                           52 bits physical, 57 bits virtual
CPU(s):                                  192
On-line CPU(s) list:                     0-191
Thread(s) per core:                      2
Core(s) per socket:                      48
Socket(s):                               2
NUMA node(s):                            2
Vendor ID:                               AuthenticAMD
CPU family:                              25
Model:                                   17
Model name:                              AMD EPYC 9474F 48-Core Processor
Stepping:                                1
Frequency boost:                         enabled
CPU MHz:                                 1492.835
CPU max MHz:                             4114.4229
CPU min MHz:                             1500.0000
BogoMIPS:                                7189.43
Virtualization:                          AMD-V
L1d cache:                               3 MiB
L1i cache:                               3 MiB
L2 cache:                                96 MiB
L3 cache:                                512 MiB
NUMA node0 CPU(s):                       0-47,96-143
NUMA node1 CPU(s):                       48-95,144-191
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Old microcode:             Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Mitigation; Safe RET
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; Enhanced / Automatic IBRS; IBPB conditional; STIBP always-on; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Mitigation; Clear CPU buffers
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Mitigation; IBPB before exit to userspace
Flags:                                   fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good amd_lbr_v2 nopl xtopology nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba perfmon_v2 ibrs ibpb stibp ibrs_enhanced vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local user_shstk avx512_bf16 clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif x2avic v_spec_ctrl vnmi avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid overflow_recov succor smca fsrm flush_l1d debug_swap

G++:

g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:

clang version 10.0.0-4ubuntu1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@WardBrian
WardBrian merged commit 747fa35 into develop Nov 13, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants